fix: Remove executable bit from default file mode #14497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramikg
changed the title
Signed-off-by: ramikg <72725910+ramikg@users.noreply.github.com>
|
I like this change, but it is a departure from the default in 2.7, which is "all files are executable. I'm in favor of merging this, as long as there's a note in the 2.7-2.8 release docs explaining the change. |
Signed-off-by: ramikg <72725910+ramikg@users.noreply.github.com>
Signed-off-by: ramikg <72725910+ramikg@users.noreply.github.com>
|
Thank you, I've added a note. |
crenshaw-dev
approved these changes
Jul 18, 2023
|
/cherry-pick release-2.8 |
gcp-cherry-pick-bot bot
pushed a commit
that referenced
this pull request
Jul 18, 2023
* Fix file/directory opening mode Signed-off-by: ramikg <72725910+ramikg@users.noreply.github.com> * Fix TestUntgz/preserves_file_mode Signed-off-by: ramikg <72725910+ramikg@users.noreply.github.com> * Mention file mode fix in 2.7-2.8 release docs Signed-off-by: ramikg <72725910+ramikg@users.noreply.github.com> --------- Signed-off-by: ramikg <72725910+ramikg@users.noreply.github.com>
crenshaw-dev
pushed a commit
that referenced
this pull request
Jul 18, 2023
* Fix file/directory opening mode * Fix TestUntgz/preserves_file_mode * Mention file mode fix in 2.7-2.8 release docs --------- Signed-off-by: ramikg <72725910+ramikg@users.noreply.github.com> Co-authored-by: Rami <72725910+ramikg@users.noreply.github.com>
yyzxw
pushed a commit
to yyzxw/argo-cd
that referenced
this pull request
Aug 9, 2023
* Fix file/directory opening mode Signed-off-by: ramikg <72725910+ramikg@users.noreply.github.com> * Fix TestUntgz/preserves_file_mode Signed-off-by: ramikg <72725910+ramikg@users.noreply.github.com> * Mention file mode fix in 2.7-2.8 release docs Signed-off-by: ramikg <72725910+ramikg@users.noreply.github.com> --------- Signed-off-by: ramikg <72725910+ramikg@users.noreply.github.com>
Closed
tesla59
pushed a commit
to tesla59/argo-cd
that referenced
this pull request
Dec 16, 2023
* Fix file/directory opening mode Signed-off-by: ramikg <72725910+ramikg@users.noreply.github.com> * Fix TestUntgz/preserves_file_mode Signed-off-by: ramikg <72725910+ramikg@users.noreply.github.com> * Mention file mode fix in 2.7-2.8 release docs Signed-off-by: ramikg <72725910+ramikg@users.noreply.github.com> --------- Signed-off-by: ramikg <72725910+ramikg@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Untgzunnecessarily callsos.OpenFilewith a file mode which has all executable bits set.This PR removes the executable bits.
Checklist: