Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(security): don't allow app enumeration via RevisionChartDetails (cherry-pick #14512) #14517

Merged
merged 1 commit into from
Jul 15, 2023

Conversation

gcp-cherry-pick-bot[bot]
Copy link

Cherry-picked fix(security): don't allow app enumeration via RevisionChartDetails (#14512)

  • fix(security): don't allow app enumeration via RevisionChartDetails

Signed-off-by: Michael Crenshaw 350466+crenshaw-dev@users.noreply.github.com

  • better app name

Signed-off-by: Michael Crenshaw 350466+crenshaw-dev@users.noreply.github.com


Signed-off-by: Michael Crenshaw 350466+crenshaw-dev@users.noreply.github.com

…14512)

* fix(security): don't allow app enumeration via RevisionChartDetails

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>

* better app name

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>

---------

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
@codecov
Copy link

codecov bot commented Jul 14, 2023

Codecov Report

Patch coverage: 66.66% and project coverage change: +0.03 🎉

Comparison is base (6cece3f) 49.77% compared to head (a0feb99) 49.80%.

Additional details and impacted files
@@               Coverage Diff               @@
##           release-2.8   #14517      +/-   ##
===============================================
+ Coverage        49.77%   49.80%   +0.03%     
===============================================
  Files              261      261              
  Lines            44750    44745       -5     
===============================================
+ Hits             22273    22286      +13     
+ Misses           20287    20266      -21     
- Partials          2190     2193       +3     
Impacted Files Coverage Δ
server/application/application.go 50.75% <66.66%> (+0.83%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@crenshaw-dev crenshaw-dev merged commit 6678007 into release-2.8 Jul 15, 2023
20 of 23 checks passed
@crenshaw-dev crenshaw-dev deleted the cherry-pick-10fd87-release-2.8 branch July 15, 2023 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant