fix: 'argocd-server-tls' Secret should be loaded from informer #14522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
alexmt
added
cherry-pick/2.5
cherry-pick/2.6
cherry-pick/2.7
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #14522 +/- ##
==========================================
+ Coverage 49.61% 49.79% +0.17%
==========================================
Files 256 261 +5
Lines 43800 44751 +951
==========================================
+ Hits 21733 22283 +550
- Misses 19934 20274 +340
- Partials 2133 2194 +61
☔ View full report in Codecov by Sentry. |
|
Thank you for fixing that @alexmt |
crenshaw-dev
approved these changes
Jul 17, 2023
|
/cherry-pick release-2.8 |
gcp-cherry-pick-bot bot
pushed a commit
that referenced
this pull request
Jul 17, 2023
Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
|
/cherry-pick release-2.7 |
gcp-cherry-pick-bot bot
pushed a commit
that referenced
this pull request
Jul 17, 2023
Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
|
/cherry-pick release-2.6 |
|
/cherry-pick release-2.5 |
gcp-cherry-pick-bot bot
pushed a commit
that referenced
this pull request
Jul 17, 2023
Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
gcp-cherry-pick-bot bot
pushed a commit
that referenced
this pull request
Jul 17, 2023
Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
crenshaw-dev
pushed a commit
that referenced
this pull request
Jul 17, 2023
… (#14546) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> Co-authored-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
crenshaw-dev
pushed a commit
that referenced
this pull request
Jul 17, 2023
… (#14547) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> Co-authored-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
crenshaw-dev
pushed a commit
that referenced
this pull request
Jul 17, 2023
… (#14548) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> Co-authored-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
crenshaw-dev
pushed a commit
that referenced
this pull request
Jul 17, 2023
… (#14549) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> Co-authored-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
Jneville0815
pushed a commit
to radiusmethod/argo-cd
that referenced
this pull request
Jul 18, 2023
…roj#14522) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>
schakrad
pushed a commit
to schakrad/argo-cd
that referenced
this pull request
Jul 24, 2023
…roj#14522) (argoproj#14547) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> Co-authored-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> Signed-off-by: schakrad <58915923+schakrad@users.noreply.github.com>
yyzxw
pushed a commit
to yyzxw/argo-cd
that referenced
this pull request
Aug 9, 2023
…roj#14522) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
Closed
tesla59
pushed a commit
to tesla59/argo-cd
that referenced
this pull request
Dec 16, 2023
…roj#14522) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Argo CD is loading
argocd-server-tlsSecret directly from Kubernetes although it is available in informer. This results in thousands of unnecessary k8s API calls and most likelly slows down reconciliation.