-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ui): Correct pod log viewer to support short log lines (#14402) #14543
fix(ui): Correct pod log viewer to support short log lines (#14402) #14543
Conversation
…j#14402 Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
@terrytangyuan how far back do we need to cherry-pick this? 2.7 I think? |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #14543 +/- ##
==========================================
- Coverage 49.79% 49.79% -0.01%
==========================================
Files 261 261
Lines 44751 44755 +4
==========================================
+ Hits 22283 22284 +1
- Misses 20274 20276 +2
- Partials 2194 2195 +1
☔ View full report in Codecov by Sentry. |
v2.7 seems reasonable (I am using v2.7.6). Could you also help test the change locally to make sure nothing else breaks? |
/cherry-pick release-2.8 |
/cherry-pick release-2.7 |
@rbreeze have you had a chance to test locally? If so, I'll smash merge. |
Let me perform more testing before merging this since this will be cherry-picked. |
I was about to test, but |
@crenshaw-dev Verified that this looks good locally. |
…j#14402 (argoproj#14543) Signed-off-by: Yuan Tang <terrytangyuan@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>
…j#14402 (argoproj#14543) (argoproj#14562) Signed-off-by: Yuan Tang <terrytangyuan@gmail.com> Co-authored-by: Yuan Tang <terrytangyuan@gmail.com> Signed-off-by: schakrad <58915923+schakrad@users.noreply.github.com>
…j#14402 (argoproj#14543) Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
…j#14402 (argoproj#14543) Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
Fixes #14402