Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ApplicationSet Controller crashes when tag is not closed; panic: Cannot find end tag="}}"(#14227) ( #14227) #14689

Merged
merged 2 commits into from
Jul 24, 2023
Merged

fix: ApplicationSet Controller crashes when tag is not closed; panic: Cannot find end tag="}}"(#14227) ( #14227) #14689

merged 2 commits into from
Jul 24, 2023

Conversation

schakrad
Copy link
Contributor

Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.

Please see Contribution FAQs if you have questions about your pull-request.

@schakrad
appSet fix
e9e3c26 
Signed-off-by: schakrad <58915923+schakrad@users.noreply.github.com>
@crenshaw-dev
Update applicationset/utils/utils_test.go
f4180a2 
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
@codecov
Copy link

codecov bot commented Jul 24, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (0ee33e5) 48.93% compared to head (f4180a2) 48.94%.

Additional details and impacted files 
@@             Coverage Diff              @@
##           release-2.7   #14689   +/-   ##
============================================
  Coverage        48.93%   48.94%           
============================================
  Files              247      247           
  Lines            42802    42805    +3     
============================================
+ Hits             20946    20949    +3     
  Misses           19743    19743           
  Partials          2113     2113
Files Changed Coverage Δ
applicationset/utils/utils.go 71.01% <100.00%> (+0.31%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@crenshaw-dev
Copy link
Collaborator

/cherry-pick release-2.6

@crenshaw-dev
Copy link
Collaborator

/cherry-pick release-2.5

@crenshaw-dev crenshaw-dev changed the title fix: ApplicationSet fix release2.7( #14227) fix: ApplicationSet Controller crashes when tag is not closed; panic: Cannot find end tag="}}"(#14227) ( #14227) Jul 24, 2023
@crenshaw-dev crenshaw-dev merged commit fbe7f8f into argoproj:release-2.7 Jul 24, 2023
18 of 19 checks passed
@gcp-cherry-pick-bot gcp-cherry-pick-bot bot mentioned this pull request Jul 24, 2023
Merged
gcp-cherry-pick-bot bot pushed a commit that referenced this pull request Jul 24, 2023
@schakrad @crenshaw-dev
fix: ApplicationSet Controller crashes when tag is not closed; panic:…
f8e3ddb 
… Cannot find end tag="}}"(#14227) ( #14227) (#14689)

* appSet fix

Signed-off-by: schakrad <58915923+schakrad@users.noreply.github.com>

* Update applicationset/utils/utils_test.go

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>

---------

Signed-off-by: schakrad <58915923+schakrad@users.noreply.github.com>
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
gcp-cherry-pick-bot bot pushed a commit that referenced this pull request Jul 24, 2023
@schakrad @crenshaw-dev
fix: ApplicationSet Controller crashes when tag is not closed; panic:…
5b47f4c 
… Cannot find end tag="}}"(#14227) ( #14227) (#14689)

* appSet fix

Signed-off-by: schakrad <58915923+schakrad@users.noreply.github.com>

* Update applicationset/utils/utils_test.go

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>

---------

Signed-off-by: schakrad <58915923+schakrad@users.noreply.github.com>
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
@gcp-cherry-pick-bot gcp-cherry-pick-bot bot mentioned this pull request Jul 24, 2023
Merged
crenshaw-dev added a commit that referenced this pull request Jul 24, 2023
@gcp-cherry-pick-bot @schakrad @crenshaw-dev
fix: ApplicationSet Controller crashes when tag is not closed; panic:…
261e665 
… Cannot find end tag="}}"(#14227) ( #14227) (#14689) (#14690)

* appSet fix



* Update applicationset/utils/utils_test.go



---------

Signed-off-by: schakrad <58915923+schakrad@users.noreply.github.com>
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Co-authored-by: schakrad <58915923+schakrad@users.noreply.github.com>
Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
crenshaw-dev added a commit that referenced this pull request Jul 24, 2023
@gcp-cherry-pick-bot @schakrad @crenshaw-dev
fix: ApplicationSet Controller crashes when tag is not closed; panic:…
df7e6df 
… Cannot find end tag="}}"(#14227) ( #14227) (#14689) (#14691)

* appSet fix



* Update applicationset/utils/utils_test.go



---------

Signed-off-by: schakrad <58915923+schakrad@users.noreply.github.com>
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Co-authored-by: schakrad <58915923+schakrad@users.noreply.github.com>
Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crenshaw-dev crenshaw-dev crenshaw-dev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@schakrad @crenshaw-dev