Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(controller): log failed attempts to update operation state (cherry-pick #14273) #14729

Merged
merged 1 commit into from
Jul 27, 2023

Conversation

gcp-cherry-pick-bot[bot]
Copy link

Cherry-picked fix(controller): log failed attempts to update operation state (#14273)

  • fix(controller): log failed attempts to update operation state

Signed-off-by: Michael Crenshaw 350466+crenshaw-dev@users.noreply.github.com

  • new package name

Signed-off-by: Michael Crenshaw 350466+crenshaw-dev@users.noreply.github.com

  • Update controller/appcontroller_test.go

Signed-off-by: Michael Crenshaw 350466+crenshaw-dev@users.noreply.github.com


Signed-off-by: Michael Crenshaw 350466+crenshaw-dev@users.noreply.github.com

* fix(controller): log failed attempts to update operation state

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>

* new package name

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>

* Update controller/appcontroller_test.go

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>

---------

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
@codecov
Copy link

codecov bot commented Jul 26, 2023

Codecov Report

Patch coverage: 70.90% and project coverage change: +0.01% 🎉

Comparison is base (0157f41) 48.91% compared to head (168bcb7) 48.92%.

Additional details and impacted files
@@               Coverage Diff               @@
##           release-2.7   #14729      +/-   ##
===============================================
+ Coverage        48.91%   48.92%   +0.01%     
===============================================
  Files              247      247              
  Lines            42847    42852       +5     
===============================================
+ Hits             20957    20964       +7     
+ Misses           19770    19769       -1     
+ Partials          2120     2119       -1     
Files Changed Coverage Δ
controller/appcontroller.go 53.19% <70.90%> (+0.08%) ⬆️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@crenshaw-dev crenshaw-dev merged commit 316be4e into release-2.7 Jul 27, 2023
20 of 23 checks passed
@crenshaw-dev crenshaw-dev deleted the cherry-pick-a23e5f-release-2.7 branch July 27, 2023 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant