Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GPG signature validation doesn't work on multi-source values #14773

Open
3 tasks done
shmargum opened this issue Jul 28, 2023 · 3 comments
Open
3 tasks done

GPG signature validation doesn't work on multi-source values #14773

shmargum opened this issue Jul 28, 2023 · 3 comments
Assignees
Labels
enhancement New feature or request multi-source-apps Bugs or enhancements related to multi-source Applications.

Comments

@shmargum
Copy link

shmargum commented Jul 28, 2023

Checklist:

  • I've searched in the docs and FAQ for my answer: https://bit.ly/argocd-faq.
  • I've included steps to reproduce the bug.
  • I've pasted the output of argocd version.

Describe the bug

An application with helm chart from source A and values from source B says target revision in source B is not signed when it is indeed signed.

To Reproduce

sources:
  - repoURL: 'git@github.com:my-org/my-repo-1.git'
    path: charts/test
    targetRevision: master
    helm:
      valueFiles:
        - values/test.yaml
        - $values1/charts/test/values/test.yaml
  - repoURL: 'git@github.com:my-org/my-repo-2.git'
    targetRevision: master
    ref: values1

Expected behavior

Expecting ArgoCD to recognize the commit is signed.

Screenshots

Screenshot 2023-07-28 at 2 15 46 PM Screenshot 2023-07-28 at 2 17 48 PM

Version

v2.7.7+4650bb2.dirty

Logs

Paste any relevant application logs here.
@shmargum shmargum added the bug Something isn't working label Jul 28, 2023
@crenshaw-dev crenshaw-dev added the multi-source-apps Bugs or enhancements related to multi-source Applications. label Jul 28, 2023
@jannfis
Copy link
Member

jannfis commented Aug 3, 2023

Thanks. I have a PoC working to support multiple sources among some other new features that I submit shortly along with a proposal.

@jannfis jannfis self-assigned this Aug 8, 2023
@jannfis
Copy link
Member

jannfis commented Aug 8, 2023

Proposal: #14964

@ishitasequeira ishitasequeira added enhancement New feature or request and removed bug Something isn't working labels Apr 1, 2024
@zadjadr
Copy link

zadjadr commented Apr 5, 2024

I also see an issue with this if we use an external helm chart with values taken from an internal repository.

For example:

Source 2 will always be signed with my GPG key, e.g ABCEXAMPLE while Source 1 is not signed since its a helm repository. Argocd will not sync because the target at Source 1 is not signed.

Is there any workaround for this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request multi-source-apps Bugs or enhancements related to multi-source Applications.
Projects
None yet
Development

No branches or pull requests

5 participants