Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(appset): bitbucket server scm provider EOF on empty repo (cherry-pick #14411) #15204

Merged
merged 1 commit into from
Aug 24, 2023

Conversation

gcp-cherry-pick-bot[bot]
Copy link

Cherry-picked fix(appset): bitbucket server scm provider EOF on empty repo (#14411)

  • fix bitbucket server scm provider EOF on empty repo default branch check

Signed-off-by: Jedrzej Kotkowski jedrzejk143@gmail.com

  • add unit test for bitbucketServer empty repo

Signed-off-by: Jedrzej Kotkowski jedrzejk143@gmail.com

  • check for EOF explicitly

Signed-off-by: Jedrzej Kotkowski jedrzejk143@gmail.com


Signed-off-by: Jedrzej Kotkowski jedrzejk143@gmail.com

* fix bitbucket server scm provider EOF on empty repo default branch check

Signed-off-by: Jedrzej Kotkowski <jedrzejk143@gmail.com>

* add unit test for bitbucketServer empty repo

Signed-off-by: Jedrzej Kotkowski <jedrzejk143@gmail.com>

* check for EOF explicitly

Signed-off-by: Jedrzej Kotkowski <jedrzejk143@gmail.com>

---------

Signed-off-by: Jedrzej Kotkowski <jedrzejk143@gmail.com>
@codecov
Copy link

codecov bot commented Aug 24, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (ece9d1b) 48.92% compared to head (fb9b1a1) 48.92%.

Additional details and impacted files
@@             Coverage Diff              @@
##           release-2.7   #15204   +/-   ##
============================================
  Coverage        48.92%   48.92%           
============================================
  Files              247      247           
  Lines            42913    42914    +1     
============================================
+ Hits             20995    20996    +1     
  Misses           19795    19795           
  Partials          2123     2123           
Files Changed Coverage Δ
...ationset/services/scm_provider/bitbucket_server.go 88.53% <100.00%> (+0.07%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@crenshaw-dev crenshaw-dev merged commit 514ff2c into release-2.7 Aug 24, 2023
18 of 22 checks passed
@crenshaw-dev crenshaw-dev deleted the cherry-pick-605c87-release-2.7 branch August 24, 2023 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants