Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync waves #1544

Closed
alexec opened this issue Apr 30, 2019 · 1 comment
Closed

Sync waves #1544

alexec opened this issue Apr 30, 2019 · 1 comment
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@alexec
Copy link
Contributor

alexec commented Apr 30, 2019

Is your feature request related to a problem? Please describe.

There is a need to perform a phased rollout of multiple deployments where deployment B needs to be deployed only after deployment B is fully ready.

Typically this use case is solved by defining an init container in deployment B, which queries its dependency (deployment A) to be up. However, there are some scenarios where init containers are unable to solve the problem.

For example, one scenario is that deployment B should not start until deployment A is running with same version of deployment B. An init container performing a version check would not help here because deployment A may be running with multiple replicas, and could potentially be returning a mix of versions, when deployment A is performing a rolling update.

Describe the solution you'd like

Be able to state the wave that a resource should be deployed in. Do not start wave N until wave N-1 is healthy.

  annotations:
    "argocd.argoproj.io/sync-wave": "1"

Describe alternatives you've considered
Weights.

Additional context

#1396

@alexec alexec added the enhancement New feature or request label Apr 30, 2019
@alexec alexec added this to the v1.1 milestone Apr 30, 2019
@alexec alexec self-assigned this May 2, 2019
@jessesuen
Copy link
Member

I reopened #1396 and prefer to use consistent terminology with helm hook-weights.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants