Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs - site is confused about current version #18407

Open
2 of 3 tasks
runofthemill opened this issue May 24, 2024 · 2 comments
Open
2 of 3 tasks

Docs - site is confused about current version #18407

runofthemill opened this issue May 24, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@runofthemill
Copy link

Checklist:

  • I've searched in the docs and FAQ for my answer: https://bit.ly/argocd-faq.
  • I've included steps to reproduce the bug.
  • I've pasted the output of argocd version.

This may be an RTD bug/change, but the docs are showing this warning in the header: You are viewing the docs for an unreleased version of Argo CD

Screenshot shows the version selected is older, and correctly shows a modal indicating that, but regardless of the selected version, the top banner is present.

Also notable is the window object READTHEDOCS_DATA which is used in the version check is undefined, making me think it may be a change from RTD.

To Reproduce

Visit https://argo-cd.readthedocs.io/en/stable or select any other version

Expected behavior

Only show You are viewing the docs for an unreleased version of Argo CD when viewing https://argo-cd.readthedocs.io/en/latest/.

Screenshots

SCR-20240524-ijsl

Version

N/A

Logs

N/A

@runofthemill runofthemill added the bug Something isn't working label May 24, 2024
@surajyadav1108
Copy link
Contributor

related #18239

@morremeyer
Copy link
Contributor

I built the docs locally with mkdocs directly to investigate

python3 -m venv /tmp/argocd
source /tmp/argocd/bin/activate
pip install -r docs/requirements.txt

# Install mkdocs if you don't have it, on macOS: brew install mkdocs
mkdocs serve

The version selector was fixed in #18239, but the banner still exists when on stable. It looks like selecting stable does not actually load the stable docs, since the URL is /stable, but the version selector shows latest.

Also, I noticed that the 2.10 and 2.11 releases are completely missing from the version selection.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants