-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Label CRD Resources by Default or Conditionally #18565
Comments
@acudovs Just to clarify, you mention
Does that mean you currently have SharedResourceWarning? I think that is the expected behavior. When a CRD is managed by two application and the CRD is different, if the two applications use a different version, the version of the CRD will constantly change based on which application was sync the last. SharedResourceWarning with FailOnSharedResource will prevent that behavior. |
All resources, including CRDs, are managed by a single ArgoCD application named "my-cert-manager". Let's consider the Deployment resource: Originally, An exception to this is the CRDs: For CRDs, It seems FailOnSharedResource does not applicable in this case, since there is a single ArgoCD application but different |
@acudovs can you share your application definition? When using helm, Argo will use the Is it possible that you specify a I added this issue to the next contributor meeting to discuss and document why CRDs are not tracked. You could switch to the newer tracking method to resolve this issue, or specify the application name as the release name. |
Here is the ArgoCD Application definition
By default, |
Summary
Currently, CustomResourceDefinition (CRD) resources are not labeled by ArgoCD, which leads to SharedResourceWarning issues when managing CRDs. This issue suggests that CRD resources should be labeled by default or conditionally, similar to other ArgoCD managed resources.
https://github.com/argoproj/argo-cd/blob/3703a1ee/cmd/argocd/commands/app.go#L1358
Motivation
In scenarios where CRDs are part of Application, not labeling them correctly causes SharedResourceWarning issues. For example, when installing cert-manager CRDs they are managed by both argocd/my-cert-manager and cert-manager applications. Proper labeling of CRDs will ensure consistent management and reduce conflicts and warnings, making it easier to track and manage CRDs within the ArgoCD environment.
Proposal
To address the issue, CRDs should be labeled by default or conditionally based on user configurations.
Questions
Why CDR resources are not labeled? Can you consider labeling CDRs by default or conditionally?
The text was updated successfully, but these errors were encountered: