Helm dependency conditions/tags are not respected with multisource

[ep4sh]

Checklist:

• [ ✅ ] I've searched in the docs and FAQ for my answer: https://bit.ly/argocd-faq.
• [ ✅] I've included steps to reproduce the bug.
• [ ✅] I've pasted the output of argocd version.

Describe the bug
Helm dependency conditions/tags are not respected with multiple Sources for an Application

To Reproduce

1. Checkout dependencies disable: https://github.com/ep4sh/bla-values/blob/main/values.yaml

2. create app and deploy

apiVersion: argoproj.io/v1alpha1
kind: Application
metadata:
  finalizers:
    - resources-finalizer.argocd.argoproj.io
  name: ep4sh-bla
  namespace: argocd
spec:
  sources:
    - repoURL: 'https://prometheus-community.github.io/helm-charts'
      chart: prometheus
      targetRevision: 15.7.1
      helm:
        valueFiles:
        - $values/values.yaml
    - repoURL: 'https://github.com/ep4sh/bla-values.git'
      targetRevision: HEAD
      ref: values
  project: system
  destination:
    server: "https://kubernetes.default.svc"
    namespace: default
  syncPolicy:
    syncOptions:
      - ApplyOutOfSyncOnly=true
    automated:
      selfHeal: true
    retry:
      limit: 2
      backoff:
        duration: 5s
        factor: 2
        maxDuration: 3m

Expected behavior
Since kube-state-metrics / prometheus-node-exporter and others are disabled, no one of them should NOT be deployed.

Screenshots

Version

version v2.11.3+3f344d5
build date 2024-06-06T08:42:00Z
helm v3.14.4+g81c902a

[agaudreault]

@ep4sh Can you edit the issue and add a description of the bug?

[ep4sh]

Hi @agaudreault, done

[agaudreault]

@ep4sh You use the chart prometheus version 15.7.1, which is based on https://github.com/prometheus-community/helm-charts/blob/prometheus-15.7.1/charts/prometheus/Chart.yaml. In this chart dependencies, there is only KubeStateMetrics listed as a dependency. In your values file, you provide a configuration for kube-state-metrics which will not match, and other dependency which do not exist for this version.

Closing as this is a configuration issue an not an ArgoCD issue.

[ep4sh]

Hi @agaudreault, I created this prometheus chart just for example - to reproduce the issue.

In reality, I faced an issue when used my own application with dependencies, like Grafana and so on. I'm not sure if it's just a single Prometheus configuration issue.

Just install the same with pure helm and you'll get the difference. Thanks!