Helm v3 CRD are not deployed.

[Synehan]

Checklist:

• I've searched in the docs and FAQ for my answer: http://bit.ly/argocd-faq.
• I've included steps to reproduce the bug.
• I've pasted the output of argocd version.

Describe the bug

ArgoCD does not install the CRD if using Helm v3.

Since ArgoCD uses helm template to generate the kubernetes manifests to deploy, and Helm v3, by default, does not generates crds with helm template (it is by default with helm install), ArgoCD does not deploys crds stored in crds directory.

helm template can generate crds through --include-crds option.

To Reproduce

Create a new application with a helm 3 chart (apiVersion v2) including a CRD (https://github.com/Synehan/argocd-helm3-crd-bug). See that argocd does not deploys crds.

Expected behavior

CRD are deployed with helm v3 charts (apiVersion v2)

Version

argocd-server: v1.5.0-rc3+9b21c25
  BuildDate: 2020-03-30T22:06:21Z
  GitCommit: 9b21c257839a005a04a8197bec362c4607e75dab
  GitTreeState: clean
  GoVersion: go1.14
  Compiler: gc
  Platform: linux/amd64
  Ksonnet Version: v0.13.1
  Kustomize Version: Version: {Version:kustomize/v3.2.1 GitCommit:d89b448c745937f0cf1936162f26a5aac688f840 BuildDate:2019-09-27T00:10:52Z GoOs:linux GoArch:amd64}
  Helm Version: version.BuildInfo{Version:"v3.1.1", GitCommit:"afe70585407b420d0097d07b21c47dc511525ac8", GitTreeState:"clean", GoVersion:"go1.13.8"}
  Kubectl Version: v1.14.0

Logs

From repo-server:

time="2020-04-02T13:39:44Z" level=info msg="helm template . --name-template config-connector --namespace cnrm-system --values /tmp/values-127274178.yaml --api-versions v1 --api-versions apiregistration.k8s.io/v1 --api-versions apiregistration.k8s.io/v1beta1 --api-versions extensions/v1beta1 --api-versions apps/v1 --api-versions apps/v1beta2 --api-versions apps/v1beta1 --api-versions authentication.k8s.io/v1 --api-versions authentication.k8s.io/v1beta1 --api-versions authorization.k8s.io/v1 --api-versions authorization.k8s.io/v1beta1 --api-versions autoscaling/v1 --api-versions autoscaling/v2beta1 --api-versions batch/v1 --api-versions batch/v1beta1 --api-versions certificates.k8s.io/v1beta1 --api-versions networking.k8s.io/v1 --api-versions networking.k8s.io/v1beta1 --api-versions policy/v1beta1 --api-versions rbac.authorization.k8s.io/v1 --api-versions rbac.authorization.k8s.io/v1beta1 --api-versions storage.k8s.io/v1 --api-versions storage.k8s.io/v1beta1 --api-versions admissionregistration.k8s.io/v1beta1 --api-versions apiextensions.k8s.io/v1beta1 --api-versions scheduling.k8s.io/v1 --api-versions scheduling.k8s.io/v1beta1 --api-versions coordination.k8s.io/v1 --api-versions coordination.k8s.io/v1beta1 --api-versions node.k8s.io/v1beta1 --api-versions crd.projectcalico.org/v1 --api-versions dex.coreos.com/v1 --api-versions monitoring.coreos.com/v1 --api-versions velero.io/v1 --api-versions dex.cloudplatform.renault.com/v1alpha --api-versions argoproj.io/v1alpha1 --api-versions authentication.istio.io/v1alpha1 --api-versions bitnami.com/v1alpha1 --api-versions certmanager.k8s.io/v1alpha1 --api-versions internal.autoscaling.k8s.io/v1alpha1 --api-versions kiali.io/v1alpha1 --api-versions monitoring.kiali.io/v1alpha1 --api-versions nodemanagement.gke.io/v1alpha1 --api-versions rbac.istio.io/v1alpha1 --api-versions scalingpolicy.kope.io/v1alpha1 --api-versions acme.cert-manager.io/v1alpha2 --api-versions cert-manager.io/v1alpha2 --api-versions config.istio.io/v1alpha2 --api-versions networking.istio.io/v1alpha3 --api-versions cloud.google.com/v1beta1 --api-versions logging.banzaicloud.io/v1beta1 --api-versions networking.gke.io/v1beta1 --api-versions management.cattle.io/v3 --api-versions project.cattle.io/v3 --api-versions metrics.k8s.io/v1beta1" dir=/tmp/helm225494319/config-connector execID=xIu0d

[abdennour]

same issue

[abdennour]

any good news about this issue ?

[rhysjtevans]

Looking for an update too @mayzhang2000

[crenshaw-dev]

This issue should have been solved with the PR above. If you're still encountering it with >= 1.5.1 please add instructions to reproduce the issue (i.e. your Argo CD version and the chart/version it's failing with).

[1234]

@abdennour @rhysjtevans
include crds in your helm template using --include-crds like in following example:

helm repo add argo-cd https://argoproj.github.io/argo-helm
helm template argocd argo-cd/argo-cd -f configs.yaml -f controller.yaml -f dex.yaml -f redis.yaml -f reposerver.yaml -f server.yaml -n argocd --include-crds > deployment.yaml
server.yaml -n argocd > deployment.yaml
kubectl apply -f deployment.yaml

NOTE If you get an error like this after first run:

unable to recognize no matches for kind "Application" in version "argoproj.io/v1alpha1"
unable to recognize no matches for kind "AppProject" in version "argoproj.io/v1alpha1"

just run the command again, this happens because you’ve just installed the CRD Application and trying to install an instance of it.