Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore CRD status diff by default #3393

Closed
alexmt opened this issue Apr 9, 2020 · 3 comments
Closed

Ignore CRD status diff by default #3393

alexmt opened this issue Apr 9, 2020 · 3 comments
Labels
component:core Syncing, diffing, cluster state cache enhancement New feature or request type:usability Enhancement of an existing feature

Comments

@alexmt
Copy link
Collaborator

alexmt commented Apr 9, 2020

Summary

For some reason some Helm charts include CRD definitions with an empty status. Examples:

I suspect this is required to CRD delete conditions on every kubectl apply. The status is immediately modified by Kubernetes and Argo CD detecting it as a deviation ( #3391, #2239).

Motivation

The workaround is to configure Argo CD to ignore CRD status. Because an issue is happening for multiple users lets include that configuration by default.

@alexmt alexmt added the enhancement New feature or request label Apr 9, 2020
@jannfis jannfis added component:core Syncing, diffing, cluster state cache type:usability Enhancement of an existing feature labels May 14, 2020
@albqmasqeet
Copy link

albqmasqeet commented Aug 22, 2020

Docs say this should be happening already ?

https://argoproj.github.io/argo-cd/user-guide/diffing/

  resource.compareoptions: |
    # disables status field diffing in specified resource types
    # 'crd' - CustomResourceDefinition-s (default)
    # 'all' - all resources
    # 'none' - disabled
    ignoreResourceStatusField: crd

@darshanime
Copy link
Member

correct, 🔝 was introduced in 1.7

@alexmt can we close this? it was fixed in #3754

@alexmt
Copy link
Collaborator Author

alexmt commented Aug 25, 2020

Agree. This can be closed. Thank you @darshanime !

@alexmt alexmt closed this as completed Aug 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:core Syncing, diffing, cluster state cache enhancement New feature or request type:usability Enhancement of an existing feature
Projects
None yet
Development

No branches or pull requests

4 participants