Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ArgoCD fails to create the nginx-ingress webhook #3714

Closed
estahn opened this issue Jun 4, 2020 · 4 comments
Closed

ArgoCD fails to create the nginx-ingress webhook #3714

estahn opened this issue Jun 4, 2020 · 4 comments
Labels
bug Something isn't working

Comments

@estahn
Copy link
Contributor

estahn commented Jun 4, 2020

Describe the bug

ArgoCD fails to create the nginx-ingress webhook due to the cluster role not being installed.

See slack conversation here.

https://github.com/helm/charts/blob/master/stable/nginx-ingress/templates/admission-webhooks/job-patch/clusterrole.yaml

To Reproduce

Install nginx-ingress with webhook enabled.

Expected behavior

Install webhook.

Version

v1.5.1+8a3b36b

Logs

The output on the pods seems to be fine, so I guess the hooks are not executed correctly:

argocd@argocd-repo-server-5df4d5fb89-dwpqr:/tmp/https:__kubernetes-charts.storage.googleapis.com_$ helm template nginx-ingress-1.39.0.tgz --set controller.admissionWebhooks.enabled=true | grep -A3 job-patch/clusterrole.yaml
# Source: nginx-ingress/templates/admission-webhooks/job-patch/clusterrole.yaml
apiVersion: rbac.authorization.k8s.io/v1
kind: ClusterRole
metadata:
argocd@argocd-repo-server-5df4d5fb89-dwpqr:/tmp/https:__kubernetes-charts.storage.googleapis.com_$ helm2 template nginx-ingress-1.39.0.tgz --set controller.admissionWebhooks.enabled=true | grep -A3 job-patch/clusterrole.yaml
# Source: nginx-ingress/templates/admission-webhooks/job-patch/clusterrole.yaml
apiVersion: rbac.authorization.k8s.io/v1
kind: ClusterRole
argocd@argocd-repo-server-5df4d5fb89-dwpqr:/tmp/https:__kubernetes-charts.storage.googleapis.com_$
@estahn estahn added the bug Something isn't working label Jun 4, 2020
@jdfalk
Copy link
Contributor

jdfalk commented Jun 10, 2020

Argocd doesn't follow the spirit of how helm deploys things. It creates the service account and instantly deletes it. There is another bug open on this because it also happens for the prometheus operator. I really wish they would make some progress as this is a huge hassle to run these things manually then have argo take over.

See: #3502

@alexmt
Copy link
Collaborator

alexmt commented Jun 16, 2020

I think this is a duplicate of #2737 . I really hope to get it fixed in 1.7 release.

Closing this ticket as a duplicate. @estahn let me know please if I'm missing something and ticket has to be reopened

@alexmt alexmt closed this as completed Jun 16, 2020
@foxracle
Copy link

@alexmt Is there a timeline for this fix to be released? I am still running into this issue with ingress Nginx.

argocd version: 1.7.7

@TheAggressive
Copy link

Ran into this too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants