feat: Add configurable Helm version (#3872) #4111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jannfis
reviewed
Aug 17, 2020
|
Hey, this is cool! Will take a closer look tomorrow :) |
Cool :) |
loxley
force-pushed
the
add-configurable-helm-version
branch
from
e8a7968
to
cbb5b27
Compare
Codecov Report
@@ Coverage Diff @@
## master #4111 +/- ##
==========================================
+ Coverage 42.78% 42.81% +0.03%
==========================================
Files 124 124
Lines 18257 18286 +29
==========================================
+ Hits 7812 7830 +18
- Misses 9448 9455 +7
- Partials 997 1001 +4
Continue to review full report at Codecov.
|
This commit adds support for configurable Helm version either via declarative syntax or via argocd cli. New helm option 'Version' added to the ApplicationSourceHelm struct which can be either 'v2' or 'v3'. Argocd app create accepts '--helm-version' that also looks for the same Helm versions as above.
loxley
force-pushed
the
add-configurable-helm-version
branch
from
cbb5b27
to
6699414
Compare
|
@alexmt Any idea when this will be included in a release? I checked the I checked https://github.com/argoproj/argo-cd/blob/v1.7.5/cmd/argocd/commands/app.go#L739 for example but |
3 tasks
jon-walton
pushed a commit
to playstudios/argo-cd
that referenced
this pull request
Oct 27, 2020
This commit adds support for configurable Helm version either via declarative syntax or via argocd cli. New helm option 'Version' added to the ApplicationSourceHelm struct which can be either 'v2' or 'v3'. Argocd app create accepts '--helm-version' that also looks for the same Helm versions as above.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds support for configurable Helm version either via
declarative syntax or via argocd cli.
New helm option 'Version' added to the ApplicationSourceHelm
struct which can be either 'v2' or 'v3'.
Argocd app create accepts '--helm-version' that also looks for the
same Helm versions as above.
Closes #3872 .
Checklist: