feat(ui): Migrate project summary settings to EditablePanel for parity with rest of UI #4400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4400 +/- ##
==========================================
+ Coverage 41.18% 41.29% +0.10%
==========================================
Files 122 122
Lines 16584 16584
==========================================
+ Hits 6830 6848 +18
+ Misses 8772 8750 -22
- Partials 982 986 +4
Continue to review full report at Codecov.
|
alexmt
requested changes
Sep 23, 2020
There was a problem hiding this comment.
Thanks a lot for working on it @rbreeze !
Added few comments. Also, the orphaned resources panel seems to need a little more polishing. Worked on small PR that implements some ideas: rbreeze#1
- add icons that visualize enabled/disabled state
- add help icons with the additional description in tooltip
- removed redundant 'Orphaned' words from labels within 'Orphaned Resources' panel
- make sure that positions of edit and view controller are consistent
ui/src/app/settings/components/project-details/project-details.tsx
Outdated
Show resolved
Hide resolved
ui/src/app/settings/components/project-details/project-details.tsx
Outdated
Show resolved
Hide resolved
alexmt
requested changes
Sep 24, 2020
ui/src/app/settings/components/project-details/project-details.tsx
Outdated
Show resolved
Hide resolved
ui/src/app/settings/components/project-details/project-details.tsx
Outdated
Show resolved
Hide resolved
jsoref
reviewed
Oct 21, 2020
| <EditablePanel | ||
| save={item => this.saveProject(item)} | ||
| values={proj} | ||
| title={<React.Fragment>CLUSTER RESOURCE DENY LIST {helpTip('Cluster-scoped K8s API Groups and Kinds which are not permitted to be deployed')}</React.Fragment>} |
There was a problem hiding this comment.
It feels like this change from blacklist/whitelist to deny list/allow list should have been called out in a commit message / release note...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist: