Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Allow ingress traffic to argocd-server by default #6179

Merged
merged 1 commit into from May 10, 2021

Conversation

jannfis
Copy link
Member

@jannfis jannfis commented May 6, 2021

Related to #6156, which introduced NetworkPolicies for Argo CD components but disallowed any Ingress traffic to the argocd-server pods by default.

This PR changes default behavior to allow all Ingress traffic to argocd-server.

Signed-off-by: jannfis jann@mistrust.net

Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).

Signed-off-by: jannfis <jann@mistrust.net>
@jannfis jannfis requested review from alexmt and jessesuen May 6, 2021 11:53
@codecov
Copy link

codecov bot commented May 6, 2021

Codecov Report

Merging #6179 (eb84864) into master (8b6af8b) will increase coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6179      +/-   ##
==========================================
+ Coverage   41.13%   41.21%   +0.07%     
==========================================
  Files         147      147              
  Lines       19968    19850     -118     
==========================================
- Hits         8214     8181      -33     
+ Misses      10622    10549      -73     
+ Partials     1132     1120      -12     
Impacted Files Coverage Δ
server/application/application.go 30.91% <0.00%> (+0.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b6af8b...eb84864. Read the comment docs.

@jannfis jannfis merged commit 29b4c4d into argoproj:master May 10, 2021
alexmt pushed a commit that referenced this pull request May 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants