fix: controller should refresh app before running sync operation #6294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #6294 +/- ##
==========================================
- Coverage 41.09% 41.06% -0.04%
==========================================
Files 151 151
Lines 19931 19929 -2
==========================================
- Hits 8190 8183 -7
- Misses 10612 10617 +5
Partials 1129 1129
Continue to review full report at Codecov.
|
alexmt
force-pushed
the
5592-fix-operation-stale-app
branch
from
abfd17b
to
f22f401
Compare
jessesuen
reviewed
May 21, 2021
controller/appcontroller.go
Outdated
Comment on lines
668
to
679
| if app.Operation != nil { | ||
| // If we get here, we are about process an operation but we cannot rely on informer since it might has stale data. | ||
| // So always retrieve the latest version to ensure it is not stale to avoid unnecessary syncing. | ||
| freshApp, err := ctrl.applicationClientset.ArgoprojV1alpha1().Applications(ctrl.namespace).Get(context.Background(), app.ObjectMeta.Name, metav1.GetOptions{}) | ||
| if err != nil { | ||
| log.Errorf("Failed to retrieve latest application state: %v", err) | ||
| return | ||
| } | ||
| app = freshApp | ||
| } | ||
|
|
There was a problem hiding this comment.
minor difference, but I think it might be better to put this at the beginning of processRequestedAppOperation
There was a problem hiding this comment.
Actually nvmd. the other code would benefit from a fresh app
There was a problem hiding this comment.
Can you add a comment that this code can be deleted after #6296 is fixed?
jessesuen
approved these changes
May 21, 2021
Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
alexmt
force-pushed
the
5592-fix-operation-stale-app
branch
from
f22f401
to
a3d499e
Compare
alexmt
pushed a commit
that referenced
this pull request
May 21, 2021
Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Alexander Matyushentsev AMatyushentsev@gmail.com
Closes #5592
Closes #1125