Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add missing --container flag to 'argocd app logs' command #6320

Merged
merged 1 commit into from May 26, 2021

Conversation

alexmt
Copy link
Collaborator

@alexmt alexmt commented May 25, 2021

Signed-off-by: Alexander Matyushentsev AMatyushentsev@gmail.com

Closes #6099

PR add missing --container flag and allows streaming logs of pods with multiple containers

Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
@alexmt alexmt requested a review from mayzhang2000 May 25, 2021 23:15
@alexmt alexmt added the cherry-pick/2.0 Candidate for cherry picking into the 2.0 release branch label May 25, 2021
Copy link
Contributor

@mayzhang2000 mayzhang2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented May 25, 2021

Codecov Report

Merging #6320 (bfae927) into master (32f60d3) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6320      +/-   ##
==========================================
- Coverage   41.03%   41.02%   -0.01%     
==========================================
  Files         151      151              
  Lines       19950    19953       +3     
==========================================
  Hits         8186     8186              
- Misses      10636    10639       +3     
  Partials     1128     1128              
Impacted Files Coverage Δ
cmd/argocd/commands/app.go 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 32f60d3...bfae927. Read the comment docs.

@alexmt alexmt merged commit 5fd7ffd into argoproj:master May 26, 2021
@alexmt alexmt deleted the 6099-app-logs-container branch May 26, 2021 00:37
alexmt pushed a commit that referenced this pull request May 26, 2021
Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
@jannfis jannfis added the needs-verification PR requires pre-release verification label Jun 25, 2021
@alexmt alexmt removed the needs-verification PR requires pre-release verification label Aug 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick/2.0 Candidate for cherry picking into the 2.0 release branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

argocd app log is missing --container flag
4 participants