Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prevent 'cannot read property "filter" of undefined' during nodes filtering #6453

Merged
merged 1 commit into from Jun 10, 2021

Conversation

alexmt
Copy link
Collaborator

@alexmt alexmt commented Jun 10, 2021

Closes #6298

Signed-off-by: Alexander Matyushentsev AMatyushentsev@gmail.com

…s filtering

Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
@alexmt alexmt added the cherry-pick/2.0 Candidate for cherry picking into the 2.0 release branch label Jun 10, 2021
@alexmt alexmt requested a review from mayzhang2000 June 10, 2021 21:13
Copy link
Contributor

@mayzhang2000 mayzhang2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Jun 10, 2021

Codecov Report

Merging #6453 (41f7a9c) into master (2da0e81) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6453   +/-   ##
=======================================
  Coverage   41.07%   41.07%           
=======================================
  Files         152      152           
  Lines       20144    20144           
=======================================
  Hits         8274     8274           
  Misses      10734    10734           
  Partials     1136     1136           
Impacted Files Coverage Δ
util/settings/settings.go 46.75% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2da0e81...41f7a9c. Read the comment docs.

@alexmt alexmt merged commit fba25d8 into argoproj:master Jun 10, 2021
@alexmt alexmt deleted the 6298-info-filter-crash branch June 10, 2021 22:47
@jannfis jannfis added the needs-verification PR requires pre-release verification label Jun 25, 2021
alexmt pushed a commit that referenced this pull request Jul 22, 2021
…s filtering (#6453)

Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
@alexmt alexmt removed the needs-verification PR requires pre-release verification label Aug 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick/2.0 Candidate for cherry picking into the 2.0 release branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ArgoCD UI cannot read property "filter" of undefined
3 participants