Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the Unstable Docs Version Warning banner to Header #6624

Closed
3 tasks done
iam-veeramalla opened this issue Jul 2, 2021 · 3 comments · Fixed by #6682
Closed
3 tasks done

Fix the Unstable Docs Version Warning banner to Header #6624

iam-veeramalla opened this issue Jul 2, 2021 · 3 comments · Fixed by #6682
Labels
bug/priority:urgent Bug should be fixed immediately bug Something isn't working documentation Issue is related to missing or incorrect documentation type:docs Missing or incomplete documentation

Comments

@iam-veeramalla
Copy link
Member

Checklist:

  • I've searched in the docs and FAQ for my answer: https://bit.ly/argocd-faq.
  • I've included steps to reproduce the bug.
  • I've pasted the output of argocd version.

Describe the bug
The Unstable docs version warning banner is not fixed to the header.

When someone lands on Old/Unstable docs page from google search they see a warning banner and a link to stable docs, which is good. However this disappears as they scroll down on the docs, there is a good chance that someone would not see it on a very first sight and scroll down.

Also, I would suggest if we can change the warning/recommendation banner to a strong font and colour.

To Reproduce

Google search for the Argo CD Docs would mostly land you on the older version of docs and you should see the issue that I mentioned in the description.

Screenshots

Screenshot 2021-07-03 at 12 17 21 AM

Version
NA

NA

Logs
NA

Paste any relevant application logs here.
@iam-veeramalla iam-veeramalla added the bug Something isn't working label Jul 2, 2021
@iam-veeramalla
Copy link
Member Author

@reginapizza, @saumeya I think this should be an easy bug to fix If I am not mistaken :)

@saumeya
Copy link
Contributor

saumeya commented Jul 5, 2021

I'll take a look.

@jannfis jannfis added bug/priority:urgent Bug should be fixed immediately type:docs Missing or incomplete documentation labels Jul 5, 2021
@saumeya
Copy link
Contributor

saumeya commented Jul 9, 2021

#6682
@reginapizza Please could you review.

@agilgur5 agilgur5 added the documentation Issue is related to missing or incorrect documentation label Jan 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug/priority:urgent Bug should be fixed immediately bug Something isn't working documentation Issue is related to missing or incorrect documentation type:docs Missing or incomplete documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants