Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Custom Styles feature is broken #7067

Merged
merged 1 commit into from Aug 24, 2021

Conversation

alexmt
Copy link
Collaborator

@alexmt alexmt commented Aug 24, 2021

Signed-off-by: Alexander Matyushentsev AMatyushentsev@gmail.com

Closes #7065

PR re-introduces deprecated --staticassets flag to argocd-server. The flag allows users to serve additional static assets to enable custom styling feature. For backward compatibility the default flag value is /shared/app

Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
@codecov
Copy link

codecov bot commented Aug 24, 2021

Codecov Report

Merging #7067 (3f90499) into master (d6973c7) will increase coverage by 0.02%.
The diff coverage is 62.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7067      +/-   ##
==========================================
+ Coverage   41.06%   41.08%   +0.02%     
==========================================
  Files         158      158              
  Lines       21305    21294      -11     
==========================================
+ Hits         8748     8749       +1     
+ Misses      11304    11291      -13     
- Partials     1253     1254       +1     
Impacted Files Coverage Δ
server/server.go 54.85% <62.50%> (+1.24%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d6973c7...3f90499. Read the comment docs.

Copy link
Contributor

@mayzhang2000 mayzhang2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@rbreeze rbreeze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexmt alexmt merged commit 1d3d03f into argoproj:master Aug 24, 2021
@alexmt alexmt deleted the 7065-broken-css-styles branch August 24, 2021 22:08
alexmt pushed a commit that referenced this pull request Aug 24, 2021
Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
plakyda-codefresh pushed a commit to plakyda-codefresh/argo-cd that referenced this pull request Sep 28, 2021
Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
Signed-off-by: viktorplakida <plakyda1@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Custom Styles feature is broken
3 participants