Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: health check for openshift DeploymentConfig #7114

Merged
merged 2 commits into from Sep 3, 2021
Merged

feat: health check for openshift DeploymentConfig #7114

merged 2 commits into from Sep 3, 2021

Conversation

ishitasequeira
Copy link
Member

@ishitasequeira ishitasequeira commented Aug 30, 2021 •
edited

Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).

Signed off by Ishita Sequeira

@codecov
Copy link

codecov bot commented Aug 30, 2021 •
edited

Codecov Report

Merging #7114 (22c1318) into master (2405482) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #7114   +/-   ##
=======================================
  Coverage   41.14%   41.14%           
=======================================
  Files         158      158           
  Lines       21230    21230           
=======================================
  Hits         8736     8736           
  Misses      11241    11241           
  Partials     1253     1253

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2405482...22c1318. Read the comment docs.

@ishitasequeira ishitasequeira marked this pull request as draft August 30, 2021 15:36
@ishitasequeira ishitasequeira marked this pull request as ready for review August 30, 2021 16:57
jannfis
jannfis requested changes Sep 3, 2021
View reviewed changes
Copy link
Member

@jannfis jannfis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ishitasequeira. I have one comment, please see below.

resource_customizations/apps.openshift.io/DeploymentConfig/health.lua Outdated
return health_check
end
end
end
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if obj.status is nil, we'll return nothing. Please initialize health_check and return it in Progressing state for this case.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @jannfis for the review. I have added the Progressing status.

@ishitasequeira
feat: health check for openshift DeploymentConfig
8da0d63 
Signed-off-by: ishitasequeira <isequeir@redhat.com>
@ishitasequeira
Address PR comments
22c1318 
Signed-off-by: ishitasequeira <isequeir@redhat.com>
@ishitasequeira ishitasequeira force-pushed the openshift-deployment-config-health-check branch from bff29c5 to 22c1318 Compare September 3, 2021 13:29
@jannfis
Copy link
Member

jannfis commented Sep 3, 2021

LGTM, thank you @ishitasequeira

@jannfis jannfis merged commit c0f2bf5 into argoproj:master Sep 3, 2021
plakyda-codefresh pushed a commit to plakyda-codefresh/argo-cd that referenced this pull request Sep 28, 2021
@ishitasequeira @plakyda1
feat: health check for openshift DeploymentConfig (argoproj#7114)
346ac72 
* feat: health check for openshift DeploymentConfig

Signed-off-by: ishitasequeira <isequeir@redhat.com>

* Address PR comments

Signed-off-by: ishitasequeira <isequeir@redhat.com>
Signed-off-by: viktorplakida <plakyda1@gmail.com>
@fredcb
Copy link

fredcb commented Mar 24, 2022

I really like thes feature and just disovered it, but I can't find info about how to use it. Is there any reference to this somewhere that I missed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jannfis jannfis jannfis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ishitasequeira @jannfis @fredcb