fix: Argo CD should not use cached git/helm revision during app creation/update validation #7244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jessesuen
approved these changes
Sep 17, 2021
alexmt
force-pushed
the
no-cache-on-app-change
branch
from
9d570ef
to
7a8504a
Compare
…ion/update validation Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
alexmt
force-pushed
the
no-cache-on-app-change
branch
from
7a8504a
to
db04a11
Compare
Codecov Report
@@ Coverage Diff @@
## master #7244 +/- ##
=======================================
Coverage 41.08% 41.08%
=======================================
Files 160 160
Lines 21474 21475 +1
=======================================
+ Hits 8822 8823 +1
Misses 11387 11387
Partials 1265 1265
Continue to review full report at Codecov.
|
alexmt
pushed a commit
that referenced
this pull request
Sep 17, 2021
…ion/update validation (#7244) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
plakyda-codefresh
pushed a commit
to plakyda-codefresh/argo-cd
that referenced
this pull request
Sep 21, 2021
…ion/update validation (argoproj#7244) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> Signed-off-by: viktorplakida <plakyda1@gmail.com>
plakyda-codefresh
pushed a commit
to plakyda-codefresh/argo-cd
that referenced
this pull request
Sep 28, 2021
…ion/update validation (argoproj#7244) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> Signed-off-by: viktorplakida <plakyda1@gmail.com>
3 tasks
3 tasks
mickkael
pushed a commit
to mickkael/argo-cd
that referenced
this pull request
Oct 4, 2021
Tagger: Alexander Matyushentsev <AMatyushentsev@gmail.com> Date: Wed Sep 29 14:43:42 2021 -0700 ## Quick Start ### Non-HA: ```bash kubectl create namespace argocd kubectl apply -n argocd -f https://raw.githubusercontent.com/argoproj/argo-cd/v2.1.3/manifests/install.yaml ``` #### HA: ```bash kubectl create namespace argocd kubectl apply -n argocd -f https://raw.githubusercontent.com/argoproj/argo-cd/v2.1.3/manifests/ha/install.yaml ``` #### Bug Fixes - fix: core-install.yaml always refers to latest argocd image (argoproj#7321) - fix: handle applicationset backup forbidden error (argoproj#7306) - fix: Argo CD should not use cached git/helm revision during app creation/update validation (argoproj#7244) commit 053bfbe Author: Alexander Matyushentsev <Alexander_Matyushentsev@intuit.com> Date: Wed Sep 29 14:05:18 2021 -0700 fix: core-install.yaml always refers to latest argocd image (argoproj#7321) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> diff --git a/hack/update-manifests.sh b/hack/update-manifests.sh index 0d4e37e9c..b2fafb3d5 100755 --- a/hack/update-manifests.sh +++ b/hack/update-manifests.sh @@ -31,6 +31,7 @@ $KUSTOMIZE version cd ${SRCROOT}/manifests/base && $KUSTOMIZE edit set image quay.io/argoproj/argocd=${IMAGE_NAMESPACE}/argocd:${IMAGE_TAG} cd ${SRCROOT}/manifests/ha/base && $KUSTOMIZE edit set image quay.io/argoproj/argocd=${IMAGE_NAMESPACE}/argocd:${IMAGE_TAG} +cd ${SRCROOT}/manifests/core-install && $KUSTOMIZE edit set image quay.io/argoproj/argocd=${IMAGE_NAMESPACE}/argocd:${IMAGE_TAG} echo "${AUTOGENMSG}" > "${SRCROOT}/manifests/install.yaml" $KUSTOMIZE build "${SRCROOT}/manifests/cluster-install" >> "${SRCROOT}/manifests/install.yaml" diff --git a/manifests/core-install/kustomization.yaml b/manifests/core-install/kustomization.yaml index e6b768c65..f502d9beb 100644 --- a/manifests/core-install/kustomization.yaml +++ b/manifests/core-install/kustomization.yaml @@ -7,4 +7,8 @@ resources: - ../base/config - ../base/application-controller - ../base/repo-server -- ../base/redis \ No newline at end of file +- ../base/redis +images: +- name: quay.io/argoproj/argocd + newName: quay.io/argoproj/argocd + newTag: latest ============ END COMMIT MESSAGE ============== ============BEGIN RELEASE NOTES================= ## Quick Start ### Non-HA: ```bash kubectl create namespace argocd kubectl apply -n argocd -f https://raw.githubusercontent.com/argoproj/argo-cd/v2.1.3/manifests/install.yaml ``` #### HA: ```bash kubectl create namespace argocd kubectl apply -n argocd -f https://raw.githubusercontent.com/argoproj/argo-cd/v2.1.3/manifests/ha/install.yaml ``` #### Bug Fixes - fix: core-install.yaml always refers to latest argocd image (argoproj#7321) - fix: handle applicationset backup forbidden error (argoproj#7306) - fix: Argo CD should not use cached git/helm revision during app creation/update validation (argoproj#7244)
mickkael
pushed a commit
to mickkael/argo-cd
that referenced
this pull request
Oct 4, 2021
Tagger: Alexander Matyushentsev <AMatyushentsev@gmail.com> Date: Wed Sep 29 14:43:42 2021 -0700 ## Quick Start ### Non-HA: ```bash kubectl create namespace argocd kubectl apply -n argocd -f https://raw.githubusercontent.com/argoproj/argo-cd/v2.1.3/manifests/install.yaml ``` #### HA: ```bash kubectl create namespace argocd kubectl apply -n argocd -f https://raw.githubusercontent.com/argoproj/argo-cd/v2.1.3/manifests/ha/install.yaml ``` #### Bug Fixes - fix: core-install.yaml always refers to latest argocd image (argoproj#7321) - fix: handle applicationset backup forbidden error (argoproj#7306) - fix: Argo CD should not use cached git/helm revision during app creation/update validation (argoproj#7244) commit 053bfbe Author: Alexander Matyushentsev <Alexander_Matyushentsev@intuit.com> Date: Wed Sep 29 14:05:18 2021 -0700 fix: core-install.yaml always refers to latest argocd image (argoproj#7321) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> diff --git a/hack/update-manifests.sh b/hack/update-manifests.sh index 0d4e37e9c..b2fafb3d5 100755 --- a/hack/update-manifests.sh +++ b/hack/update-manifests.sh @@ -31,6 +31,7 @@ $KUSTOMIZE version cd ${SRCROOT}/manifests/base && $KUSTOMIZE edit set image quay.io/argoproj/argocd=${IMAGE_NAMESPACE}/argocd:${IMAGE_TAG} cd ${SRCROOT}/manifests/ha/base && $KUSTOMIZE edit set image quay.io/argoproj/argocd=${IMAGE_NAMESPACE}/argocd:${IMAGE_TAG} +cd ${SRCROOT}/manifests/core-install && $KUSTOMIZE edit set image quay.io/argoproj/argocd=${IMAGE_NAMESPACE}/argocd:${IMAGE_TAG} echo "${AUTOGENMSG}" > "${SRCROOT}/manifests/install.yaml" $KUSTOMIZE build "${SRCROOT}/manifests/cluster-install" >> "${SRCROOT}/manifests/install.yaml" diff --git a/manifests/core-install/kustomization.yaml b/manifests/core-install/kustomization.yaml index e6b768c65..f502d9beb 100644 --- a/manifests/core-install/kustomization.yaml +++ b/manifests/core-install/kustomization.yaml @@ -7,4 +7,8 @@ resources: - ../base/config - ../base/application-controller - ../base/repo-server -- ../base/redis \ No newline at end of file +- ../base/redis +images: +- name: quay.io/argoproj/argocd + newName: quay.io/argoproj/argocd + newTag: latest ============ END COMMIT MESSAGE ============== ============BEGIN RELEASE NOTES================= ## Quick Start ### Non-HA: ```bash kubectl create namespace argocd kubectl apply -n argocd -f https://raw.githubusercontent.com/argoproj/argo-cd/v2.1.3/manifests/install.yaml ``` #### HA: ```bash kubectl create namespace argocd kubectl apply -n argocd -f https://raw.githubusercontent.com/argoproj/argo-cd/v2.1.3/manifests/ha/install.yaml ``` #### Bug Fixes - fix: core-install.yaml always refers to latest argocd image (argoproj#7321) - fix: handle applicationset backup forbidden error (argoproj#7306) - fix: Argo CD should not use cached git/helm revision during app creation/update validation (argoproj#7244)
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Alexander Matyushentsev AMatyushentsev@gmail.com
As of v2.1 Argo CD caches resolved revisions. Cache is refreshed every 3 mins, if refresh is requested explicitly. The PR introduces cache refresh when application changed/created.