Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide v2 of the argocd image tag and refer to it instead of latest #7497

Closed
mikolajprzybysz opened this issue Oct 20, 2021 · 1 comment
Closed
Labels
enhancement New feature or request

Comments

@mikolajprzybysz
Copy link
Contributor

mikolajprzybysz commented Oct 20, 2021

Summary

Provide v2 of the argocd image tag and refer to it instead of latest

Motivation

This PR #7321 has introduced referring to the latest argocd image, which is very problematic, because if you ever deliver argocd image v3 that is not compatible with v2 you will break everyone's setups.

Proposal

As I understand original author intention was to not be forced to update image version with each release and so my proposal will be in this spirit. I suggest to create tag argocd:v2 in quay.io which will target most recent v2 release and refer to it instead of latest. This technique is used across docker hub images.

@mikolajprzybysz mikolajprzybysz added the enhancement New feature or request label Oct 20, 2021
@mikolajprzybysz mikolajprzybysz changed the title Provide v2 of the argocd image Provide v2 of the argocd image tag and refer to it instead of latest Oct 20, 2021
@jannfis
Copy link
Member

jannfis commented Oct 20, 2021

Hi @mikolajprzybysz, the image tag is set by Kustomize in the generated manifests that we release. In master branch, it will always be latest, but for the releases, it will have a correct version (refer to the manifests for an example).

@mikolajprzybysz mikolajprzybysz closed this as not planned Won't fix, can't repro, duplicate, stale Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants