argocd admin dashboard trying to look at /app/config/ssh/ssh_known_hosts

[james-callahan]

Describe the bug

This code

argo-cd/util/git/client.go

Line 270 in 3c874ae

log.Errorf("Could not set-up SSH known hosts callback: %v", err)

seems to be hit by argocd admin dashboard, resulting in it trying to open the path /app/config/ssh/ssh_known_hosts.

Expected behavior

argocd admin dashboard shouldn't try to look in non-existant directories. I'm not sure why it was trying to ssh anywhere anyway.... (shouldn't that only be inside of the repo server?)

Version

argocd: v2.1.5+unknown
  BuildDate: 2021-10-28T04:06:55Z
  GitCommit: 
  GitTreeState: 
  GitTag: 2.1.5
  GoVersion: go1.17.1
  Compiler: gc
  Platform: linux/amd64
FATA[0000] Argo CD server address unspecified  

Logs

ERRO[0168] Could not set-up SSH known hosts callback: open /app/config/ssh/ssh_known_hosts: no such file or directory 

[jessesuen]

argocd admin dashboard shouldn't try to look in non-existant directories. I'm not sure why it was trying to ssh anywhere anyway.... (shouldn't that only be inside of the repo server?)

Argo CD server still does some low-touch git interactions. Specifically, it needs to resolve ambiguous revisions to a concrete commit SHA, so that when it initiates a sync operation, it fills in the operation with an SHA and not the ambiguous revision.

That said, I agree with you that when dashboard is running locally, it shouldn't presume SSH environment from local setup. I think this is just a side-effect of us adapting the dashboard as a stand alone binary, vs. a hosted service.

[NotAFile]

It appears argocd app sync suffers from this too, at least in core mode. Afaict this makes it impossible to use SSH repos with argocd core right now?

[jessesuen]

Unfortunately, that is correct. To fix this, we need to change the model such that argocd-server assumes no git environment and relies entirely on the repo-server to answer any git questions like:

• what is the SHA for this ambiguous revision?

This means adding a new gRPC method to the repo-server.

[alexmt]

There is an in-progress PR #5832 .

[alexmt]

Fixed by #7966