Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: targetervision compatible without prefix refs/heads or refs/tags #7939

Merged
merged 2 commits into from Dec 15, 2021

Conversation

jomenxiao
Copy link
Contributor

Signed-off-by: jomen.xiao jomenxiao@gmail.com

Fixes: #7906

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I have signed off all my commits as required by DCO

Signed-off-by: jomen.xiao <jomenxiao@gmail.com>
@jomenxiao jomenxiao changed the title targetervision compatible without prefix refs/heads or refs/tags fix: targetervision compatible without prefix refs/heads or refs/tags Dec 15, 2021
@codecov
Copy link

codecov bot commented Dec 15, 2021

Codecov Report

Merging #7939 (5d92dea) into master (f89d40c) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7939      +/-   ##
==========================================
- Coverage   41.64%   41.64%   -0.01%     
==========================================
  Files         171      171              
  Lines       22447    22450       +3     
==========================================
+ Hits         9349     9350       +1     
- Misses      11768    11769       +1     
- Partials     1330     1331       +1     
Impacted Files Coverage Δ
util/webhook/webhook.go 62.17% <100.00%> (+0.59%) ⬆️
util/settings/settings.go 47.60% <0.00%> (-0.25%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f89d40c...5d92dea. Read the comment docs.

@pasha-codefresh
Copy link
Member

LGTM, thank you! You need to do empty commit for restart failed checks

Signed-off-by: jomenxiao <jomenxiao@gmail.com>
Copy link
Collaborator

@alexmt alexmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gitlab webhook does not work if targetRevision contains slash symbol
3 participants