Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): use consistent case for diff modes (#6464) #7945

Merged
merged 1 commit into from Dec 19, 2021

Conversation

aslafy-z
Copy link
Contributor

@aslafy-z aslafy-z commented Dec 15, 2021

Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).

Closes #5454

@aslafy-z aslafy-z changed the title fix(ui): use consistent case for diff modes fix(ui): use consistent case for diff modes (#6464) Dec 15, 2021
Signed-off-by: GitHub <noreply@github.com>
@codecov
Copy link

codecov bot commented Dec 15, 2021

Codecov Report

Merging #7945 (f34f779) into master (f89d40c) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7945      +/-   ##
==========================================
- Coverage   41.64%   41.64%   -0.01%     
==========================================
  Files         171      171              
  Lines       22447    22447              
==========================================
- Hits         9349     9347       -2     
- Misses      11768    11769       +1     
- Partials     1330     1331       +1     
Impacted Files Coverage Δ
util/settings/settings.go 47.60% <0.00%> (-0.25%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f89d40c...f34f779. Read the comment docs.

@ciiay
Copy link
Contributor

ciiay commented Dec 15, 2021

LGTM

Copy link
Member

@jannfis jannfis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @aslafy-z !

@jannfis jannfis merged commit e50d03e into argoproj:master Dec 19, 2021
@aslafy-z aslafy-z deleted the patch-1 branch December 19, 2021 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use consistent case for Compact diff/Inline Diff
3 participants