Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: issue with headless installation #7958

Merged
merged 7 commits into from Dec 16, 2021

Conversation

pasha-codefresh
Copy link
Member

@pasha-codefresh pasha-codefresh commented Dec 16, 2021

Closes: #7953

Signed-off-by: pashavictorovich <pavel@codefresh.io>
This reverts commit d0e2135

Signed-off-by: pashavictorovich <pavel@codefresh.io>
Signed-off-by: pashavictorovich <pavel@codefresh.io>
@codecov
Copy link

codecov bot commented Dec 16, 2021

Codecov Report

Merging #7958 (91637a2) into master (17c6daa) will decrease coverage by 0.20%.
The diff coverage is 75.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7958      +/-   ##
==========================================
- Coverage   41.64%   41.43%   -0.21%     
==========================================
  Files         171      173       +2     
  Lines       22450    22570     +120     
==========================================
+ Hits         9350     9353       +3     
- Misses      11769    11886     +117     
  Partials     1331     1331              
Impacted Files Coverage Δ
cmd/argocd/commands/headless/headless.go 3.61% <75.00%> (ø)
cmd/argocd/commands/headless/forward.go 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 17c6daa...91637a2. Read the comment docs.

Signed-off-by: pashavictorovich <pavel@codefresh.io>
Copy link
Contributor

@mayzhang2000 mayzhang2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexmt alexmt merged commit f9ba9e9 into argoproj:master Dec 16, 2021
alexmt pushed a commit that referenced this pull request Dec 16, 2021
fix: issue with headless installation (#7958)

Signed-off-by: pashavictorovich <pavel@codefresh.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

argocd account list and other commands fail with SIGSEGV on new installation
3 participants