Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: resource details page crashes when resource is not deployed and hide managed fields is selected #7971

Merged
merged 1 commit into from Dec 16, 2021

Conversation

alexmt
Copy link
Collaborator

@alexmt alexmt commented Dec 16, 2021

Signed-off-by: Alexander Matyushentsev AMatyushentsev@gmail.com

PR fixes the Javascript crash when resource is not deployed and hide managed fields is selected

…hide managed fields is selected

Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
@codecov
Copy link

codecov bot commented Dec 16, 2021

Codecov Report

Merging #7971 (6de1072) into master (f9ba9e9) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #7971   +/-   ##
=======================================
  Coverage   41.43%   41.43%           
=======================================
  Files         173      173           
  Lines       22570    22570           
=======================================
  Hits         9353     9353           
  Misses      11886    11886           
  Partials     1331     1331           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f9ba9e9...6de1072. Read the comment docs.

Copy link
Contributor

@mayzhang2000 mayzhang2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexmt alexmt merged commit 656f790 into argoproj:master Dec 16, 2021
alexmt pushed a commit that referenced this pull request Dec 17, 2021
…hide managed fields is selected (#7971)

Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
@chrism417
Copy link

thank you, this was driving me nuts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants