Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Grouped node list missing resources on Compact resources view #8014 #8018

Merged

Conversation

ciiay
Copy link
Contributor

@ciiay ciiay commented Dec 22, 2021

Closes #8014
Signed-off-by: ciiay yicai@redhat.com

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).

@ciiay ciiay force-pushed the ui-8014-grouped-node-list-missing-resources branch from fde1c94 to fc246bd Compare December 22, 2021 17:43
@codecov
Copy link

codecov bot commented Dec 22, 2021

Codecov Report

Merging #8018 (fc246bd) into master (800b109) will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8018      +/-   ##
==========================================
+ Coverage   41.49%   41.54%   +0.04%     
==========================================
  Files         173      174       +1     
  Lines       22591    22681      +90     
==========================================
+ Hits         9375     9422      +47     
- Misses      11885    11918      +33     
- Partials     1331     1341      +10     
Impacted Files Coverage Δ
controller/appcontroller.go 52.18% <0.00%> (-0.74%) ⬇️
cmd/argocd/commands/app.go 0.53% <0.00%> (-0.01%) ⬇️
test/testutil.go 0.00% <0.00%> (ø)
util/settings/settings.go 46.85% <0.00%> (ø)
util/argo/ignore_difference.go
util/argo/diff/ignore.go 100.00% <0.00%> (ø)
util/argo/diff/diff.go 52.27% <0.00%> (ø)
controller/state.go 74.09% <0.00%> (+6.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 800b109...fc246bd. Read the comment docs.

Copy link
Collaborator

@alexmt alexmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@alexmt alexmt merged commit 129e9ea into argoproj:master Dec 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Grouped node list missing resources on Compact resources view
2 participants