Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Opening app details shows UI error on some apps (#8016) #8019

Merged
merged 1 commit into from Dec 22, 2021

Conversation

nistei
Copy link
Contributor

@nistei nistei commented Dec 22, 2021

Fixes #8016

Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).

Signed-off-by: Niklas Steiner <niklas@sbg.at>
Copy link
Collaborator

@alexmt alexmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you! Cherry picking fix into v2.2 and v2.1 once PR is merged

@codecov
Copy link

codecov bot commented Dec 22, 2021

Codecov Report

Merging #8019 (715360c) into master (7bac2c1) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #8019   +/-   ##
=======================================
  Coverage   41.54%   41.54%           
=======================================
  Files         174      174           
  Lines       22681    22681           
=======================================
  Hits         9422     9422           
  Misses      11918    11918           
  Partials     1341     1341           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7bac2c1...715360c. Read the comment docs.

@alexmt alexmt merged commit d8c3113 into argoproj:master Dec 22, 2021
alexmt pushed a commit that referenced this pull request Dec 22, 2021
@nistei nistei deleted the fix-ui-retry-strategy branch December 22, 2021 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Opening app details shows UI error on some apps
2 participants