Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Controller panics if resource manifest has incorrect annotation #8022

Merged
merged 1 commit into from Dec 23, 2021

Conversation

alexmt
Copy link
Collaborator

@alexmt alexmt commented Dec 22, 2021

Signed-off-by: Alexander Matyushentsev AMatyushentsev@gmail.com

Closes #8020

PR upgrades gitops engine to latest version that includes controller panic fix: argoproj/gitops-engine#361

Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
@alexmt alexmt requested a review from jannfis December 22, 2021 21:50
Copy link
Member

@jannfis jannfis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Does this need to be backported to 2.1 w/ gitops-engine 0.4.x as well?

@codecov
Copy link

codecov bot commented Dec 22, 2021

Codecov Report

Merging #8022 (e4435c5) into master (000f951) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #8022   +/-   ##
=======================================
  Coverage   41.54%   41.54%           
=======================================
  Files         174      174           
  Lines       22681    22681           
=======================================
  Hits         9422     9422           
  Misses      11918    11918           
  Partials     1341     1341           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 000f951...e4435c5. Read the comment docs.

@alexmt alexmt merged commit 26f8350 into argoproj:master Dec 23, 2021
@alexmt alexmt deleted the 8020-controller-panic branch December 23, 2021 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Controller panics if resource manifest has incorrect annotation
2 participants