Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: store "Group Nodes" button state in application details preferences #8036

Merged
merged 1 commit into from Jan 3, 2022

Conversation

alexmt
Copy link
Collaborator

@alexmt alexmt commented Dec 25, 2021

Signed-off-by: Alexander Matyushentsev AMatyushentsev@gmail.com

PR allows storing "Group Nodes" button state in application details preferences

…nces

Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
@alexmt alexmt requested review from rbreeze and ciiay December 25, 2021 21:31
@codecov
Copy link

codecov bot commented Dec 25, 2021

Codecov Report

Merging #8036 (c67aec6) into master (32838b1) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #8036   +/-   ##
=======================================
  Coverage   41.54%   41.54%           
=======================================
  Files         174      174           
  Lines       22681    22681           
=======================================
  Hits         9422     9422           
  Misses      11918    11918           
  Partials     1341     1341           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 32838b1...c67aec6. Read the comment docs.

Copy link
Contributor

@mayzhang2000 mayzhang2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexmt alexmt merged commit 3247090 into argoproj:master Jan 3, 2022
@alexmt alexmt deleted the group-nodes-pref branch January 3, 2022 19:31
ciiay pushed a commit to ciiay/argo-cd that referenced this pull request Jan 4, 2022
…nces (argoproj#8036)

Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
Signed-off-by: ciiay <yicai@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants