refactor: move project filtering to server side #8102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexmt
requested review from
ciiay,
pasha-codefresh,
rbreeze,
reginapizza and
saumeya
and removed request for
pasha-codefresh
|
@ciiay, @rbreeze, @reginapizza, @saumeya, Let me know what you think, please! |
|
I agree, I think the loading indicator (which is barely noticeable) is a worthwhile tradeoff. |
Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
alexmt
force-pushed
the
project-filter-server-side
branch
from
22f61be
to
8cf2ee8
Compare
Codecov Report
@@ Coverage Diff @@
## master #8102 +/- ##
==========================================
- Coverage 41.53% 41.52% -0.01%
==========================================
Files 174 174
Lines 22703 22707 +4
==========================================
Hits 9430 9430
- Misses 11932 11936 +4
Partials 1341 1341
Continue to review full report at Codecov.
|
|
Looks great @alexmt |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Alexander Matyushentsev AMatyushentsev@gmail.com
PR moves improve applications list page performance by moving project filtering to server-side. When a user adds the project filter then both list and stream API will reduce only project-related applications which significantly reduce browser CPU usage. The disadvantage is that use will see a loading indicator after changing project filter:
Screen.Recording.2022-01-05.at.2.37.30.PM.mov
I believe the loading indicator is acceptable in this case because typically end-users select the required project once and don't change it very frequently.