Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cluster name in application destination affects controller performance #8132

Closed
alexmt opened this issue Jan 10, 2022 · 2 comments · Fixed by #8133
Closed

Cluster name in application destination affects controller performance #8132

alexmt opened this issue Jan 10, 2022 · 2 comments · Fixed by #8133
Labels
bug Something isn't working

Comments

@alexmt
Copy link
Collaborator

alexmt commented Jan 10, 2022

Describe the bug

The cluster name in the application destination affects controller performance. See attached CPU profile:

https://share.polarsignals.com/fbdddca/
image

To Reproduce

The issue is visible on a large Argo CD instance with multiple applications. Each application should be using cluster name instead of cluster server URL

Expected behavior

Usage of cluster name should not affect performance.

Version

v2.2.2
@alexmt alexmt added the bug Something isn't working label Jan 10, 2022
@yeya24
Copy link
Contributor

yeya24 commented Jan 10, 2022

Hi @alexmt, are you working on this issue now or is it open to take?

@alexmt alexmt mentioned this issue Jan 10, 2022
Merged
@alexmt
Copy link
Collaborator Author

alexmt commented Jan 10, 2022

Hello @yeya24 , I'm working on it. Just created PR with the fix: #8133

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: introduce 'byClusterName' secret index to speedup cluster server URL lookup alexmt/argo-cd
2 participants
@alexmt @yeya24