Add nodeSelector linux to Deployment and StatefulSet

[MariusGrandeAndersen]

Summary

Change installation so all pods are created on linux nodes.

Motivation

We have a Kubernetes cluster with both windows and linux nodes. Without nodeSelector the pods will randomly be created on the windows node, and will fail pulling down the container image.

Currently I have to download the manifest, edit the deployments and statefulsets, then run "kubectl apply" on my local file, and add it manually. However when I will upgrade to a new version of argocd I will have to do this process again.

(The same goes for the applicationset).

Proposal

As argocd only works on Linux,
add

      nodeSelector:
        "kubernetes.io/os": linux

to all Deployments and StatefulSets.

[saumeya]

Hi @mariusandersen, can you try using nodePlacement property in ArgoCD - https://argocd-operator.readthedocs.io/en/latest/reference/argocd/#nodeplacement-option . This can help you specify the nodeSelector which will get applied to all deployments and statefulSets.

[BrunoJuchli]

@saumeya
Thank you for the hint.
Do I understand correctly that the nodeplacement option is only available when Argo CD operator is installed?

(Argo CD operator in turn should be installed on OpenShift 4 which then again requires at least 40 cores.)

[rishabh625]

@BrunoJuchli this nodeselector is specific to your environment , I may have a Linux machine but I may label that node differently it doesn't makes sense to me to add this specific selector in manifests and yeah operator helps u automate that ,also is operator taking 40 cores of cpu?