Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Prevent possible nil-pointer deref in normalizer #8185

Merged
merged 1 commit into from Jan 14, 2022

Conversation

jannfis
Copy link
Member

@jannfis jannfis commented Jan 14, 2022

Fix a possible nil-pointer deref in diff normalizer.

Ref: https://oss-fuzz.com/testcase-detail/6263347908050944

/cc @terrytangyuan @hblixt @AdamKorcz

Signed-off-by: jannfis jann@mistrust.net

Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).

Signed-off-by: jannfis <jann@mistrust.net>
@jannfis jannfis added the fuzzing Bugs detected by fuzzer label Jan 14, 2022
@AdamKorcz
Copy link

cc @DavidKorczynski

Copy link
Member

@terrytangyuan terrytangyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Jan 14, 2022

Codecov Report

Merging #8185 (babe802) into master (cb47740) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #8185   +/-   ##
=======================================
  Coverage   41.53%   41.53%           
=======================================
  Files         174      174           
  Lines       22705    22707    +2     
=======================================
+ Hits         9430     9432    +2     
  Misses      11921    11921           
  Partials     1354     1354           
Impacted Files Coverage Δ
util/argo/normalizers/diff_normalizer.go 77.01% <100.00%> (+0.54%) ⬆️
util/settings/settings.go 47.01% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cb47740...babe802. Read the comment docs.

@jannfis jannfis merged commit 47187bd into argoproj:master Jan 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fuzzing Bugs detected by fuzzer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants