fix: application exist panic when execute api call #8188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: pashavictorovich <pavel@codefresh.io>
This reverts commit d0e2135 Signed-off-by: pashavictorovich <pavel@codefresh.io>
Signed-off-by: pashavictorovich <pavel@codefresh.io>
pasha-codefresh
changed the title
alexmt
approved these changes
Jan 14, 2022
Codecov Report
@@ Coverage Diff @@
## master #8188 +/- ##
==========================================
+ Coverage 41.53% 41.54% +0.01%
==========================================
Files 174 174
Lines 22705 22713 +8
==========================================
+ Hits 9430 9436 +6
- Misses 11921 11923 +2
Partials 1354 1354
Continue to review full report at Codecov.
|
jannfis
added
the
cherry-pick/2.2
jannfis
pushed a commit
that referenced
this pull request
Jan 15, 2022
fix: application exist panic when execute api call (#8188) Signed-off-by: pashavictorovich <pavel@codefresh.io>
|
Cherry-picked into release-2.2 branch: b1e3a07 |
cyrilix
pushed a commit
to cyrilix/argo-cd
that referenced
this pull request
Feb 15, 2022
fix: application exist panic when execute api call (argoproj#8188) Signed-off-by: pashavictorovich <pavel@codefresh.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8184
Removed generation for application , it mainly was implemented for repositories use case for better understanding why argo report that entity already exist
#2925
We can't use it for applications because isServerInferred flag that is private