Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrade k8s client to v1.23 #8213

Merged
merged 1 commit into from Jan 20, 2022
Merged

Conversation

alexmt
Copy link
Collaborator

@alexmt alexmt commented Jan 18, 2022

Signed-off-by: Alexander Matyushentsev AMatyushentsev@gmail.com

PR upgrades k8s client to v1.23. PR depends on argoproj/gitops-engine#365 (merged)

Additionally PR upgrades Golang to v1.17 since it is required by kubernetes-sigs/json#8

@codecov
Copy link

codecov bot commented Jan 18, 2022

Codecov Report

Merging #8213 (4eaecbc) into master (9155d14) will increase coverage by 0.02%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8213      +/-   ##
==========================================
+ Coverage   41.61%   41.63%   +0.02%     
==========================================
  Files         174      174              
  Lines       22717    22723       +6     
==========================================
+ Hits         9453     9461       +8     
+ Misses      11908    11907       -1     
+ Partials     1356     1355       -1     
Impacted Files Coverage Δ
util/argo/diff/diff.go 52.27% <0.00%> (ø)
util/log/logrus.go 52.17% <0.00%> (ø)
util/argo/normalizers/corev1_known_types.go 100.00% <100.00%> (ø)
util/settings/settings.go 47.25% <0.00%> (+0.23%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9155d14...4eaecbc. Read the comment docs.

@alexmt alexmt force-pushed the k8s-v1.23.1 branch 2 times, most recently from 2b0ddfc to a3cf5a1 Compare January 18, 2022 23:15
@jannfis
Copy link
Member

jannfis commented Jan 19, 2022

Just a nit: This is supposed to be a chore, not a feat

@alexmt alexmt requested a review from jannfis January 19, 2022 21:18
@alexmt alexmt marked this pull request as ready for review January 19, 2022 21:18
@jannfis
Copy link
Member

jannfis commented Jan 19, 2022

Could we please separate the bump of Golang and K8s, just to have a proper revision history for it? Then we first merge Golang bump, then K8s client libraries bump.

@alexmt
Copy link
Collaborator Author

alexmt commented Jan 19, 2022

It makes sense. Created separate PR for golang upgrade: #8229

Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
@alexmt
Copy link
Collaborator Author

alexmt commented Jan 19, 2022

Golang upgrade is merged in separate PR. Now, this PR has only k8s client-related changes. @jannfis PTAL

Copy link
Member

@jannfis jannfis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@jannfis jannfis merged commit 25698fd into argoproj:master Jan 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants