New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: upgrade k8s client to v1.23 #8213
Conversation
Codecov Report
@@ Coverage Diff @@
## master #8213 +/- ##
==========================================
+ Coverage 41.61% 41.63% +0.02%
==========================================
Files 174 174
Lines 22717 22723 +6
==========================================
+ Hits 9453 9461 +8
+ Misses 11908 11907 -1
+ Partials 1356 1355 -1
Continue to review full report at Codecov.
|
2b0ddfc
to
a3cf5a1
Compare
Just a nit: This is supposed to be a |
Could we please separate the bump of Golang and K8s, just to have a proper revision history for it? Then we first merge Golang bump, then K8s client libraries bump. |
It makes sense. Created separate PR for golang upgrade: #8229 |
Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
Golang upgrade is merged in separate PR. Now, this PR has only k8s client-related changes. @jannfis PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Signed-off-by: Alexander Matyushentsev AMatyushentsev@gmail.com
PR upgrades k8s client to v1.23. PR depends on argoproj/gitops-engine#365 (merged)
Additionally PR upgrades Golang to v1.17 since it is required by kubernetes-sigs/json#8