Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade kustomize to most recent version (v4.4.1) #8227

Merged
merged 1 commit into from Jan 19, 2022

Conversation

alexmt
Copy link
Collaborator

@alexmt alexmt commented Jan 19, 2022

Signed-off-by: Alexander Matyushentsev AMatyushentsev@gmail.com

PR upgrades kustomize v4.4.1 to the most recent stable version.

@alexmt alexmt requested a review from jannfis January 19, 2022 21:09
Copy link
Member

@jannfis jannfis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Bump of two minor versions in kustomize should be made prominently visible in the release notes, because of the history of breaking changes with kustomize.

@codecov
Copy link

codecov bot commented Jan 19, 2022

Codecov Report

Merging #8227 (2ba8afa) into master (988d760) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #8227   +/-   ##
=======================================
  Coverage   41.61%   41.61%           
=======================================
  Files         174      174           
  Lines       22717    22717           
=======================================
  Hits         9453     9453           
  Misses      11908    11908           
  Partials     1356     1356           
Impacted Files Coverage Δ
util/settings/settings.go 47.01% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 988d760...2ba8afa. Read the comment docs.

Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>

## Upgraded Kustomize Version

Note that bundled Kustomize version has been upgraded from 4.2.0 to 4.4.1.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@olebittner
Copy link

Hi all,

I realized that my current instance of argo-cd (2.2.5 / stable) is still using kustomize 4.2.0.

I found that in install-codegen-tools.sh v4.2.0 is still referenced.
In Pull-Request #6861 this file was also changed.

I'm not used to the codebase and can therefor not comprehend if this is on purpose or not.

@rishabh625
Copy link
Contributor

what benefit this upgrade brought??

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants