Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Allow external links on Applications (#3487) #8231

Merged

Conversation

keithchong
Copy link
Contributor

@keithchong keithchong commented Jan 19, 2022

Signed-off-by: Keith Chong kykchong@redhat.com

Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).

This adds to the existing support, #3487, by supporting the external link annotation that has been added to Application CRs

Specifically, a user was using Application Sets to generate Applications annotated with the external-link annotation, but they do not show up in the UI. This PR addresses this issue.

Signed-off-by: Keith Chong <kykchong@redhat.com>
@keithchong
Copy link
Contributor Author

keithchong commented Jan 20, 2022

Link on application only, no links on child resources

LinkOnlyOnApplication

Link on application, and links on child resources
MultipleLinksDetailsView

Multiple links, Applications Tile view
MultipleLinksAppTilesView

Multiple links, Applications List view
MultipleLinksAppListView

@codecov
Copy link

codecov bot commented Jan 20, 2022

Codecov Report

Merging #8231 (b2dacce) into master (dc24d05) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #8231   +/-   ##
=======================================
  Coverage   41.61%   41.61%           
=======================================
  Files         174      174           
  Lines       22717    22725    +8     
=======================================
+ Hits         9453     9458    +5     
- Misses      11908    11910    +2     
- Partials     1356     1357    +1     
Impacted Files Coverage Δ
controller/sync.go 56.96% <0.00%> (-0.55%) ⬇️
util/settings/settings.go 47.14% <0.00%> (+0.12%) ⬆️
util/argo/diff/normalize.go 44.00% <0.00%> (+4.86%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc24d05...b2dacce. Read the comment docs.

@keithchong keithchong changed the title feat: Allow external links on Application (#3487) feat: Allow external links on Applications (#3487) Jan 20, 2022
Copy link
Collaborator

@alexmt alexmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thank you!

@alexmt alexmt merged commit 83458e0 into argoproj:master Jan 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants