applicationset-controller not included in the HA Kustomization

[chrism417]

The applicationset-controller is not included here: https://github.com/argoproj/argo-cd/blob/v2.3.0/manifests/ha/cluster-install/kustomization.yaml

Therefore it's not being deployed as part of version 2.3.0.

[ohauer]

It is, https://github.com/argoproj/argo-cd/blob/v2.3.0/manifests/ha/base/kustomization.yaml

[crenshaw-dev]

@ohauer I'm pretty sure it's not. It's added to the compiled install.yaml as a separate build step, but it's not included in the kustomization.yaml by default.

argo-cd/hack/update-manifests.sh

Line 30 in f905145

# bundle_with_addons bundles given kustomize base with either stable or latest version of addons

I think this applies to both HA and non-HA kustomizations.

[rwong2888]

Below works for me, but maybe we can PR addons into the ha kustomization

kind: Kustomization

bases:
- github.com/argoproj/argo-cd/manifests/ha/cluster-install?ref=v2.3.0
- github.com/argoproj/argo-cd/manifests/addons/applicationset/stable?ref=v2.3.0

[rainerfrey-inxmail]

It is also not included in non-HA Kustomize manifests. At the very least it should be mentioned in the upgrade guide. That only says to remove references to https://github.com/argoproj-labs/applicationset, but not to add a reference to the add-on kustomization.

Also github.com/argoproj/argo-cd/manifests/addons/applicationset/stable?ref=v2.3.0 just refers to https://raw.githubusercontent.com/argoproj/applicationset/v0.4.1/manifests/install.yaml (i.e. the generated install, not the customisation directory), in the old repository where the readme says that it's deprecated.

[rainerfrey-inxmail]

It is also not included in non-HA Kustomize manifests. At the very least it should be mentioned in the upgrade guide. That only says to remove references to https://github.com/argoproj-labs/applicationset, but not to add a reference to the add-on kustomization.

Also github.com/argoproj/argo-cd/manifests/addons/applicationset/stable?ref=v2.3.0 just refers to https://raw.githubusercontent.com/argoproj/applicationset/v0.4.1/manifests/install.yaml (i.e. the generated install, not the customisation directory), in the old repository where the readme says that it's deprecated.

All this applies to the Branch release-2.3, it seems to be already addressed in master