Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add server-side apply proposal #8812

Merged
merged 11 commits into from Jun 5, 2022
Merged

Conversation

leoluz
Copy link
Collaborator

@leoluz leoluz commented Mar 17, 2022

Signed-off-by: Leonardo Luz Almeida leonardo_almeida@intuit.com

ArgoCD Server-Side Apply proposal

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).

Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com>
@codecov
Copy link

codecov bot commented Mar 17, 2022

Codecov Report

Merging #8812 (7b7c093) into master (b2fe209) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #8812   +/-   ##
=======================================
  Coverage   45.77%   45.77%           
=======================================
  Files         222      222           
  Lines       26372    26372           
=======================================
  Hits        12072    12072           
  Misses      12651    12651           
  Partials     1649     1649           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b2fe209...7b7c093. Read the comment docs.

Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com>
Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com>
Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com>
Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com>
Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com>
@leoluz leoluz marked this pull request as ready for review March 18, 2022 18:58
Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com>
Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com>
Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com>
Copy link
Contributor

@todaywasawesome todaywasawesome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benefits are clear, the behavior will be substantially better. I'm in favor.

Copy link
Collaborator

@alexmt alexmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for addressing comments @leoluz ! LGTM

@inductor
Copy link
Contributor

inductor commented Jun 5, 2022

What’s the current status of this PR? :)

@alexmt alexmt merged commit a3283d4 into argoproj:master Jun 5, 2022
@EppO
Copy link

EppO commented Jun 20, 2022

@inductor: PR for server-side apply: #9711

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants