Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bad parameters retrieved for Helm files in UI and Notifications #9175

Closed
3 tasks done
paydaycay opened this issue Apr 22, 2022 · 6 comments · Fixed by #9566
Closed
3 tasks done

Bad parameters retrieved for Helm files in UI and Notifications #9175

paydaycay opened this issue Apr 22, 2022 · 6 comments · Fixed by #9566
Labels
bug Something isn't working duplicate This issue or pull request already exists

Comments

@paydaycay
Copy link

Checklist:

  • I've searched in the docs and FAQ for my answer: https://bit.ly/argocd-faq.
  • I've included steps to reproduce the bug.
  • I've pasted the output of argocd version.

Describe the bug

Since v2.3.3 (I was in 2.2.5 before and didn't get the problem), values retrieved from Helm file in the UI are not the good ones.
The values retrieved are the default values and not the ones in my overlay file.

For example, In my default value file, I have php.image.tag equals to "helm".
The override value in my overlay file for php.image.tag is equal to "test-XXXXX".

I retrieve "helm" instead of "test-XXXXX".

I encounter the same problem in ArgoCD Notifications when I attempt to retrieve a value from Helm file in my templates.

To Reproduce

Just create a Helm chart and create an overlay file to override the default values. When you click on the application in the interface and go to "Parameters" tab, you will see the default values and not the good ones.

With ArgoCD Notifications, you can retrieve it by calling this :

{{ (call .repo.GetAppDetails).Helm.GetParameterValueByName "php.image.tag" }}

And you won't retrieve the correct ones.

Expected behavior

I expect to retrieve the correct values that are in my overlay file as it was in v2.2.5.

Screenshots

In the UI :
image
image

In the values.yaml default file :
image

In the test.yaml overlay file :
image

Part of my notifications template :
image

Part of the notification received :
image

Version

argocd: v2.3.3+07ac038
  BuildDate: 2022-03-30T00:06:18Z
  GitCommit: 07ac038a8f97a93b401e824550f0505400a8c84e
  GitTreeState: clean
  GoVersion: go1.17.6
  Compiler: gc
  Platform: linux/amd64

Logs

No relevant logs found.
@paydaycay paydaycay added the bug Something isn't working label Apr 22, 2022
@uniit
Copy link

uniit commented Apr 24, 2022

+1 Please prioritize this one b/c it misleads many people when they see different values on the parameters page and deployed applications. Otherwise please recommend a correct way how to use helm overrides in Argo.

@mihma
Copy link

mihma commented Apr 26, 2022

Similar issue after upgrading to 2.3.3. Is there a work around it?

@sgavrylenko
Copy link

have the same problem

@fredfp
Copy link

fredfp commented May 2, 2022

this seems to be a duplicate of #8808

@crenshaw-dev
Copy link
Collaborator

Agreed, duplicate. Thanks for reporting!

@crenshaw-dev crenshaw-dev reopened this Jun 3, 2022
@crenshaw-dev crenshaw-dev closed this as not planned Won't fix, can't repro, duplicate, stale Jun 3, 2022
@crenshaw-dev
Copy link
Collaborator

Yuck, I dislike GitHub's phrasing. It is planned, it's just a duplicate. :-P

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working duplicate This issue or pull request already exists
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants