Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug(gitpod): change Kubebuilder curl (#9097) #9197

Merged
merged 6 commits into from May 24, 2022

Conversation

josephmcasey
Copy link
Contributor

@josephmcasey josephmcasey commented Apr 25, 2022

Closes #9097

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).

Screenshots:

https://gitpod.io/#https://github.com/argoproj/argo-cd
gitpod-argocd

Gitpod after modifying .gitpod.Dockerfile
Screen Shot 2022-04-24 at 9 17 40 PM

No problems remaining after altering GOCACHE
GOCACHE-modified-due-to-lack-of-permission

josephmcasey and others added 4 commits April 24, 2022 21:30
Signed-off-by: Joseph Casey <me@josephmcasey.com>
* Targets path that user has permission to use

Signed-off-by: Joseph Casey <me@josephmcasey.com>
@codecov
Copy link

codecov bot commented Apr 27, 2022

Codecov Report

Merging #9197 (b153499) into master (88134c4) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #9197      +/-   ##
==========================================
- Coverage   46.06%   46.04%   -0.02%     
==========================================
  Files         217      217              
  Lines       25912    25912              
==========================================
- Hits        11936    11931       -5     
- Misses      12319    12323       +4     
- Partials     1657     1658       +1     
Impacted Files Coverage Δ
applicationset/services/scm_provider/github.go 75.29% <0.00%> (-5.89%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 88134c4...b153499. Read the comment docs.

Copy link
Collaborator

@alexmt alexmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

@alexmt alexmt merged commit 8635af3 into argoproj:master May 24, 2022
@josephmcasey josephmcasey deleted the bug/gitpod branch October 2, 2022 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot start gitpod because .gitpod.Dockerfile fails to download kubebuilder
3 participants