Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Kubernetes External Secret from docs #9251

Merged

Conversation

chaspy
Copy link
Contributor

@chaspy chaspy commented Apr 29, 2022

It seems to be deprecated.
https://github.com/external-secrets/kubernetes-external-secrets

Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).

@chaspy chaspy force-pushed the chaspy/remove-kubernetes-external-secrets branch from cb7c76a to 99b6332 Compare April 29, 2022 05:12
It seems to be deprecated.
https://github.com/external-secrets/kubernetes-external-secrets

Signed-off-by: kondo takeshi <chaspy@users.noreply.github.com>
@chaspy chaspy force-pushed the chaspy/remove-kubernetes-external-secrets branch from 99b6332 to 71baa8d Compare April 29, 2022 05:14
@codecov
Copy link

codecov bot commented Apr 29, 2022

Codecov Report

Merging #9251 (71baa8d) into master (f99e5b9) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #9251      +/-   ##
==========================================
- Coverage   45.73%   45.71%   -0.02%     
==========================================
  Files         220      220              
  Lines       26006    26006              
==========================================
- Hits        11893    11888       -5     
- Misses      12456    12460       +4     
- Partials     1657     1658       +1     
Impacted Files Coverage Δ
applicationset/services/scm_provider/github.go 75.29% <0.00%> (-5.89%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f99e5b9...71baa8d. Read the comment docs.

@chaspy chaspy marked this pull request as ready for review May 1, 2022 02:29
Copy link
Collaborator

@crenshaw-dev crenshaw-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@crenshaw-dev crenshaw-dev merged commit 016fd5f into argoproj:master May 10, 2022
@chaspy chaspy deleted the chaspy/remove-kubernetes-external-secrets branch May 10, 2022 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants