Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ApplicationSet Pull Request Generator for GitLab #9262

Closed
DevSpork opened this issue Apr 29, 2022 · 4 comments · Fixed by #9264
Closed

ApplicationSet Pull Request Generator for GitLab #9262

DevSpork opened this issue Apr 29, 2022 · 4 comments · Fixed by #9264
Labels
component:applications-set Bulk application management related enhancement New feature or request

Comments

@DevSpork
Copy link

Summary

There is a mention of the possibility to use GitLab as a source for the Pull Request Generator in the docs, still, there is no code for this type of generator present in the corresponding folder. Accordingly, it is currently not possible to use GitLab as a source.

Motivation

This would make it possible for people hosting their repositories on GitLab to use the Pull Request Generator.

Proposal

Like for GitLab, Bitbucket and GitTea there should be an option to use GitLab (SaaS and SelfHosted) as a source for the ApplicationSet Pull Request Generator.

@DevSpork DevSpork added the enhancement New feature or request label Apr 29, 2022
@iverberk
Copy link
Contributor

@DevSpork I have a branch ready for this, just need to write the tests to create the PR. This is the code so far: iverberk@69d07d6

@DevSpork
Copy link
Author

DevSpork commented May 1, 2022

@iverberk That's great news. If I can help you in any way, that doesn't require knowledge in Go let me know.

@chetan-rns chetan-rns added the component:applications-set Bulk application management related label May 2, 2022
@iverberk
Copy link
Contributor

iverberk commented May 2, 2022

Ok, #9264 is ready for review and merge (all checks should pass, otherwise I'll fix). Not sure who to ping, or just wait for the enhancement process to do its work. This is a relatively simple extension of existing functionality so I can't see much problems with it being accepted. Implementation-wise, I guess we'll find out :-)

@mcouliba
Copy link

Hello @iverberk, I just tested it and it works well
Good job!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:applications-set Bulk application management related enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants