chore: resource state tests #9307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: pashavictorovich <pavel@codefresh.io>
Codecov Report
@@ Coverage Diff @@
## master #9307 +/- ##
==========================================
+ Coverage 46.06% 46.12% +0.06%
==========================================
Files 217 217
Lines 25908 25908
==========================================
+ Hits 11934 11951 +17
+ Misses 12317 12299 -18
- Partials 1657 1658 +1
Continue to review full report at Codecov.
|
crenshaw-dev
requested changes
May 5, 2022
cmd/argocd/commands/app_test.go
Outdated
| } | ||
|
|
||
| key := rst.Key() | ||
| assert.Equal(t, key, "group/kind/namespace/name") |
There was a problem hiding this comment.
I think the assertion is backwards here. shouldn't the expected value be first?
| assert.False(t, updated) | ||
| } | ||
|
|
||
| func TestCheckResourceStatus(t *testing.T) { |
There was a problem hiding this comment.
Not required but would be nice: could you add a docstring to the checkResourceStatus function? It's not immediately obvious what it's meant to do.
Signed-off-by: pashavictorovich <pavel@codefresh.io>
leoluz
approved these changes
May 6, 2022
crenshaw-dev
approved these changes
May 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resource state tests inside app.cmd